Skip to content

r/glue_user_defined_function - add new resource#12537

Merged
bflad merged 23 commits into
hashicorp:masterfrom
DrFaust92:r/glue_user_defined_function
Aug 31, 2020
Merged

r/glue_user_defined_function - add new resource#12537
bflad merged 23 commits into
hashicorp:masterfrom
DrFaust92:r/glue_user_defined_function

Conversation

@DrFaust92

@DrFaust92 DrFaust92 commented Mar 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #3883

Release note for CHANGELOG:

resrouce_aws_glue_user_defined_function: add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueUserDefinedFunction_'
--- PASS: TestAccAWSGlueUserDefinedFunction_basic (78.63s)
--- PASS: TestAccAWSGlueUserDefinedFunction_resource_uri (106.27s)
--- PASS: TestAccAWSGlueUserDefinedFunction_disappears (40.61s)

@DrFaust92 DrFaust92 requested a review from a team March 26, 2020 14:14
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 26, 2020
@DrFaust92 DrFaust92 changed the title r/glue_user_defined_function - add new resource [WIP]r/glue_user_defined_function - add new resource Mar 26, 2020
@bflad bflad mentioned this pull request Mar 27, 2020
Closed
@DrFaust92 DrFaust92 force-pushed the r/glue_user_defined_function branch from dccf05d to 86047ba Compare April 30, 2020 07:31
@DrFaust92 DrFaust92 changed the title [WIP]r/glue_user_defined_function - add new resource r/glue_user_defined_function - add new resource Apr 30, 2020
@DrFaust92 DrFaust92 force-pushed the r/glue_user_defined_function branch from 79b52f6 to 16a1415 Compare May 19, 2020 19:33
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label May 22, 2020
@DrFaust92 DrFaust92 force-pushed the r/glue_user_defined_function branch from a47e6d7 to 3a01c71 Compare August 23, 2020 16:40
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Aug 23, 2020
@DrFaust92

DrFaust92 commented Aug 23, 2020

Copy link
Copy Markdown
Contributor Author

rebased and tested

bflad
bflad reviewed Aug 28, 2020
View reviewed changes

@bflad bflad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good just some minor items and we can get this in. 😄

Comment thread aws/resource_aws_glue_user_defined_function.go Outdated
Comment thread aws/resource_aws_glue_user_defined_function.go Outdated
Comment thread aws/resource_aws_glue_user_defined_function_test.go Outdated
Comment thread aws/resource_aws_glue_user_defined_function_test.go Outdated
Comment thread aws/resource_aws_glue_user_defined_function_test.go Outdated
Comment thread aws/resource_aws_glue_user_defined_function_test.go Outdated
Comment thread aws/resource_aws_glue_user_defined_function_test.go Outdated
Comment thread aws/resource_aws_glue_user_defined_function_test.go Outdated
Comment thread aws/resource_aws_glue_user_defined_function_test.go Outdated
@bflad bflad added this to the v3.5.0 milestone Aug 28, 2020
@bflad bflad self-assigned this Aug 28, 2020
@DrFaust92 DrFaust92 force-pushed the r/glue_user_defined_function branch from 0fbc16f to 4dba876 Compare August 29, 2020 08:50
DrFaust92 and others added 10 commits August 29, 2020 11:51
@DrFaust92
remove hadchanges
d345a8c
@DrFaust92
handle error
84d9a4d
@DrFaust92 @bflad
Update aws/resource_aws_glue_user_defined_function_test.go
a304094 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@DrFaust92 @bflad
Update aws/resource_aws_glue_user_defined_function_test.go
0e026b6 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@DrFaust92 @bflad
Update aws/resource_aws_glue_user_defined_function_test.go
aed0a5b 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@DrFaust92 @bflad
Update aws/resource_aws_glue_user_defined_function_test.go
4c2a1e8 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@DrFaust92 @bflad
Update aws/resource_aws_glue_user_defined_function_test.go
989440b 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@DrFaust92 @bflad
Update aws/resource_aws_glue_user_defined_function_test.go
d691370 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@DrFaust92 @bflad
Update aws/resource_aws_glue_user_defined_function_test.go
e919350 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@DrFaust92
fmt
9c4483a
@DrFaust92 DrFaust92 requested a review from bflad August 29, 2020 08:56
bflad
bflad approved these changes Aug 31, 2020
View reviewed changes

@bflad bflad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Output from acceptance testing:

--- PASS: TestAccAWSGlueUserDefinedFunction_disappears (13.75s)
--- PASS: TestAccAWSGlueUserDefinedFunction_basic (25.21s)
--- PASS: TestAccAWSGlueUserDefinedFunction_resource_uri (33.69s)

@bflad bflad merged commit f139170 into hashicorp:master Aug 31, 2020
bflad added a commit that referenced this pull request Aug 31, 2020
@bflad
Update CHANGELOG for #12537
b13dc9d
@ghost

ghost commented Sep 3, 2020

Copy link
Copy Markdown

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost

ghost commented Sep 30, 2020

Copy link
Copy Markdown

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bflad bflad bflad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bflad bflad

Labels

documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

Feature Request: Resource for managing AWS Glue User Defined Functions

2 participants

@DrFaust92 @bflad
⚡