r/glue_partition - add new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #3878

Release note for CHANGELOG:

resource_aws_glue_partition: add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGluePartition_'
--- PASS: TestAccAWSGluePartition_basic (65.18s)
--- PASS: TestAccAWSGluePartition_parameters (166.56s)
--- PASS: TestAccAWSGluePartition_disappears (52.11s)
--- PASS: TestAccAWSGluePartition_multipleValues (66.00s)

[DrFaust92]

rebased and tested

[ewbankkit]

Maybe add a create Glue partition ID function to parallel readAwsGluePartitionID.
There is also now precedent in moving these ID create/read functions to an internal/service package.
See e.g. aws/internal/service/ec2/id.go.

[DrFaust92]

done.

[ewbankkit]

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGluePartition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGluePartition_ -timeout 120m
=== RUN   TestAccAWSGluePartition_basic
=== PAUSE TestAccAWSGluePartition_basic
=== RUN   TestAccAWSGluePartition_disappears
=== PAUSE TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_basic
=== CONT  TestAccAWSGluePartition_disappears
    resource_aws_glue_partition_test.go:48: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGluePartition_disappears (19.76s)
--- PASS: TestAccAWSGluePartition_basic (22.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.181s

[DrFaust92]

Rebased and revised tests a bit:

--- PASS: TestAccAWSGluePartition_basic (65.18s)
--- PASS: TestAccAWSGluePartition_parameters (166.56s)
--- PASS: TestAccAWSGluePartition_disappears (52.11s)
--- PASS: TestAccAWSGluePartition_multipleValues (66.00s)

[ewbankkit]

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGluePartition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGluePartition_ -timeout 120m
=== RUN   TestAccAWSGluePartition_basic
=== PAUSE TestAccAWSGluePartition_basic
=== RUN   TestAccAWSGluePartition_multipleValues
=== PAUSE TestAccAWSGluePartition_multipleValues
=== RUN   TestAccAWSGluePartition_parameters
=== PAUSE TestAccAWSGluePartition_parameters
=== RUN   TestAccAWSGluePartition_disappears
=== PAUSE TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_basic
=== CONT  TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_parameters
=== CONT  TestAccAWSGluePartition_multipleValues
=== CONT  TestAccAWSGluePartition_disappears
    resource_aws_glue_partition_test.go:126: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGluePartition_disappears (26.79s)
--- PASS: TestAccAWSGluePartition_basic (30.38s)
--- PASS: TestAccAWSGluePartition_multipleValues (30.49s)
--- PASS: TestAccAWSGluePartition_parameters (59.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.790s

[breathingdust]

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGluePartition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGluePartition_ -timeout 120m
=== RUN   TestAccAWSGluePartition_basic
=== PAUSE TestAccAWSGluePartition_basic
=== RUN   TestAccAWSGluePartition_multipleValues
=== PAUSE TestAccAWSGluePartition_multipleValues
=== RUN   TestAccAWSGluePartition_parameters
=== PAUSE TestAccAWSGluePartition_parameters
=== RUN   TestAccAWSGluePartition_disappears
=== PAUSE TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_basic
=== CONT  TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_multipleValues
=== CONT  TestAccAWSGluePartition_parameters
2020/10/01 11:46:14 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
=== CONT  TestAccAWSGluePartition_disappears
    resource_aws_glue_partition_test.go:126: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGluePartition_disappears (16.69s)
--- PASS: TestAccAWSGluePartition_multipleValues (18.92s)
--- PASS: TestAccAWSGluePartition_basic (18.93s)
--- PASS: TestAccAWSGluePartition_parameters (43.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.203s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGluePartition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGluePartition_ -timeout 120m
=== RUN   TestAccAWSGluePartition_basic
=== PAUSE TestAccAWSGluePartition_basic
=== RUN   TestAccAWSGluePartition_multipleValues
=== PAUSE TestAccAWSGluePartition_multipleValues
=== RUN   TestAccAWSGluePartition_parameters
=== PAUSE TestAccAWSGluePartition_parameters
=== RUN   TestAccAWSGluePartition_disappears
=== PAUSE TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_basic
=== CONT  TestAccAWSGluePartition_disappears
=== CONT  TestAccAWSGluePartition_multipleValues
=== CONT  TestAccAWSGluePartition_parameters
=== CONT  TestAccAWSGluePartition_disappears
    resource_aws_glue_partition_test.go:126: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGluePartition_disappears (15.30s)
--- PASS: TestAccAWSGluePartition_basic (15.83s)
--- PASS: TestAccAWSGluePartition_multipleValues (15.97s)
--- PASS: TestAccAWSGluePartition_parameters (34.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.986s

[ghost]

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!