New Data Source: aws_workspaces_directory

[Tensho]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

New Data Source: aws_workspaces_directory (#13529)

Example

data "aws_workspaces_directory" "example" {
  directory_id = "d-9067783251"
}

Acceptance Tests

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsWorkspacesDirectory_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWorkspacesDirectory_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWorkspacesDirectory_basic
=== PAUSE TestAccDataSourceAwsWorkspacesDirectory_basic
=== CONT  TestAccDataSourceAwsWorkspacesDirectory_basic
--- PASS: TestAccDataSourceAwsWorkspacesDirectory_basic (638.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	645.726s

References

• AWS DescribeWorkspaceDirectories API Action

[gdavison]

Thanks, @Tensho. A few comments

[Tensho]

@gdavison Fixes are applied, please review it again 🙇

[gdavison]

The tests are failing with

--- FAIL: TestAccDataSourceAwsWorkspacesDirectory_basic (270.14s)
testing.go:684: Step 0 error: errors during apply:
Error: error getting WorkSpaces Directory (): ValidationException: The request is invalid.
  status code: 400, request id: f4d5374e-b83e-4b45-9a38-954295c2b6ed

It looks like the directory_id is not set

[Tensho]

@gdavison Fixed

[gdavison]

LGTM 🚀

--- PASS: TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict (1.41s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_basic (9.08s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_byOwnerName (9.50s)
--- PASS: TestAccDataSourceAwsWorkspacesDirectory_basic (602.32s)

[ghost]

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!