Skip to content

r/codeartifact_domain - new resource#13743

Merged
breathingdust merged 14 commits into
hashicorp:masterfrom
DrFaust92:f-aws_codeartifact_domain
Sep 30, 2020
Merged

r/codeartifact_domain - new resource#13743
breathingdust merged 14 commits into
hashicorp:masterfrom
DrFaust92:f-aws_codeartifact_domain

Conversation

@DrFaust92

@DrFaust92 DrFaust92 commented Jun 13, 2020

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13714

Release note for CHANGELOG:

resource_aws_codeartifact_domain - new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
--- PASS: TestAccAWSCodeArtifactDomain_basic (55.00s)
--- PASS: TestAccAWSCodeArtifactDomain_disappears (57.10s)

@DrFaust92 DrFaust92 requested a review from a team June 13, 2020 11:26
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jun 13, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jun 13, 2020
ewbankkit
ewbankkit reviewed Jun 14, 2020
View reviewed changes
Comment thread aws/resource_aws_codeartifact_domain.go Outdated
@ewbankkit

ewbankkit commented Jun 14, 2020

Copy link
Copy Markdown
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_disappears
=== PAUSE TestAccAWSCodeArtifactDomain_disappears
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactDomain_disappears
--- PASS: TestAccAWSCodeArtifactDomain_disappears (26.17s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (29.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.481s

@DrFaust92 DrFaust92 mentioned this pull request Jun 15, 2020
Merged
ewbankkit
ewbankkit reviewed Jul 16, 2020
View reviewed changes
Comment thread aws/resource_aws_codeartifact_domain.go Outdated
ewbankkit
ewbankkit reviewed Jul 16, 2020
View reviewed changes
Comment thread aws/resource_aws_codeartifact_domain.go Outdated
ewbankkit
ewbankkit reviewed Jul 16, 2020
View reviewed changes
Comment thread aws/resource_aws_codeartifact_domain.go Outdated
ewbankkit
ewbankkit reviewed Jul 16, 2020
View reviewed changes
Comment thread aws/resource_aws_codeartifact_domain_test.go Outdated
ewbankkit
ewbankkit reviewed Jul 16, 2020
View reviewed changes
Comment thread aws/resource_aws_codeartifact_domain.go Outdated
ewbankkit
ewbankkit reviewed Jul 16, 2020
View reviewed changes
Comment thread website/docs/r/codeartifact_domain.html.markdown Outdated
ewbankkit
ewbankkit reviewed Jul 16, 2020
View reviewed changes
Comment thread website/docs/r/codeartifact_domain.html.markdown Outdated
ewbankkit
ewbankkit reviewed Jul 16, 2020
View reviewed changes
Comment thread website/docs/r/codeartifact_domain.html.markdown Outdated
ewbankkit
ewbankkit reviewed Jul 17, 2020
View reviewed changes
Comment thread website/docs/r/codeartifact_domain.html.markdown Outdated
@DrFaust92 DrFaust92 force-pushed the f-aws_codeartifact_domain branch from 5c4aaae to 39620cb Compare July 19, 2020 16:58
@DrFaust92

DrFaust92 commented Jul 19, 2020

Copy link
Copy Markdown
Contributor Author

@ewbankkit, added the changes from review. Thanks as always!

@ewbankkit ewbankkit removed the request for review from a team July 19, 2020 20:33
@ewbankkit

ewbankkit commented Jul 19, 2020

Copy link
Copy Markdown
Contributor

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_disappears
=== PAUSE TestAccAWSCodeArtifactDomain_disappears
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactDomain_disappears
--- PASS: TestAccAWSCodeArtifactDomain_disappears (14.42s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (16.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.790s

@DrFaust92

DrFaust92 commented Jul 31, 2020

Copy link
Copy Markdown
Contributor Author

made some changes to better handle cross account resources as the api is account aware in its operations.

@ewbankkit

ewbankkit commented Jul 31, 2020

Copy link
Copy Markdown
Contributor

Re-verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_disappears
=== PAUSE TestAccAWSCodeArtifactDomain_disappears
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactDomain_disappears
--- PASS: TestAccAWSCodeArtifactDomain_disappears (14.30s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (15.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.975s

@DrFaust92 DrFaust92 force-pushed the f-aws_codeartifact_domain branch from 337a6e1 to c8043e6 Compare August 14, 2020 20:01
@DrFaust92 DrFaust92 force-pushed the f-aws_codeartifact_domain branch from da022ab to 7672f3b Compare August 21, 2020 21:04
@bf-sodle

bf-sodle commented Sep 25, 2020

Copy link
Copy Markdown

Is there a timeline for merging this and the other CodeArtifact resource commits? Would be very nice to have this support available for a project.

@DrFaust92 DrFaust92 force-pushed the f-aws_codeartifact_domain branch from 7672f3b to f9ca8f1 Compare September 30, 2020 08:03
ewbankkit
ewbankkit approved these changes Sep 30, 2020
View reviewed changes

@ewbankkit ewbankkit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_disappears
=== PAUSE TestAccAWSCodeArtifactDomain_disappears
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactDomain_disappears
    resource_aws_codeartifact_domain_test.go:104: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactDomain_disappears (19.32s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (21.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.739s

@breathingdust

breathingdust commented Sep 30, 2020

Copy link
Copy Markdown
Member

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_disappears
=== PAUSE TestAccAWSCodeArtifactDomain_disappears
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactDomain_disappears
    resource_aws_codeartifact_domain_test.go:104: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactDomain_disappears (14.57s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (16.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.398s

@breathingdust breathingdust added this to the v3.9.0 milestone Sep 30, 2020
@breathingdust breathingdust merged commit ad8c2d3 into hashicorp:master Sep 30, 2020
breathingdust added a commit that referenced this pull request Sep 30, 2020
@breathingdust
Update CHANGELOG for #13743
bc3b480
@ghost

ghost commented Oct 2, 2020

Copy link
Copy Markdown

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost

ghost commented Oct 31, 2020

Copy link
Copy Markdown

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2020
@DrFaust92 DrFaust92 deleted the f-aws_codeartifact_domain branch February 12, 2022 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

No one assigned

Labels

documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v3.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@DrFaust92 @ewbankkit @bf-sodle @breathingdust @maryelizbeth
⚡