r/codeartifact_domain_permissions_policy - new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13714 , Depends on #13743

Release note for CHANGELOG:

resource_aws_codeartifact_domain_permissions - new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeArtifactDomainPermissions_'
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_basic (353.49s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_owner (50.41s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears (44.62s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain (44.07s)

[ewbankkit]

I suggest renaming the resource to aws_codeartifact_domain_permissions_policy (and hence renaming the source files and functions) as this is the name in the AWS API.

[ewbankkit]

Validated acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomainPermissions_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomainPermissions_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomainPermissions_basic
=== PAUSE TestAccAWSCodeArtifactDomainPermissions_basic
=== RUN   TestAccAWSCodeArtifactDomainPermissions_disappears
=== PAUSE TestAccAWSCodeArtifactDomainPermissions_disappears
=== CONT  TestAccAWSCodeArtifactDomainPermissions_basic
=== CONT  TestAccAWSCodeArtifactDomainPermissions_disappears
--- PASS: TestAccAWSCodeArtifactDomainPermissions_disappears (28.04s)
--- PASS: TestAccAWSCodeArtifactDomainPermissions_basic (31.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.441s

I suggest also adding a test which deletes the domain

testAccCheckResourceDisappears(testAccProvider, resourceAwsCodeArtifactDomain(), resourceName),

and verifies a non-empty plan.

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomainPermissionsPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomainPermissionsPolicy_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
    resource_aws_codeartifact_domain_permissions_policy_test.go:86: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
    resource_aws_codeartifact_domain_permissions_policy_test.go:107: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain (27.63s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears (28.08s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_owner (30.61s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_basic (44.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.816s

[breathingdust]

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSCodeArtifactDomainPermissionsPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomainPermissionsPolicy_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== RUN   TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== PAUSE TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_basic
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_owner
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain
    resource_aws_codeartifact_domain_permissions_policy_test.go:107: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears
    resource_aws_codeartifact_domain_permissions_policy_test.go:86: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears_domain (16.69s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_disappears (18.57s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_owner (18.96s)
--- PASS: TestAccAWSCodeArtifactDomainPermissionsPolicy_basic (30.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.408s

[ghost]

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!