r/aws_eip - support NetworkBorderGroup attribute by drexler · Pull Request #14028 · hashicorp/terraform-provider-aws

drexler · 2020-07-02T11:27:21Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

support NetworkBorderGroup attribute for aws_eip resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_NetworkBorderGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_NetworkBorderGroup -timeout 120m
=== RUN   TestAccAWSEIP_NetworkBorderGroup
=== PAUSE TestAccAWSEIP_NetworkBorderGroup
=== CONT  TestAccAWSEIP_NetworkBorderGroup
--- PASS: TestAccAWSEIP_NetworkBorderGroup (22.76s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       22.843s

...

drexler · 2020-07-05T20:39:09Z

Full tests - had to run them one by one

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_NetworkBorderGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_NetworkBorderGroup -timeout 120m
=== RUN   TestAccAWSEIP_NetworkBorderGroup
=== PAUSE TestAccAWSEIP_NetworkBorderGroup
=== CONT  TestAccAWSEIP_NetworkBorderGroup
--- PASS: TestAccAWSEIP_NetworkBorderGroup (17.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	17.167s

 $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_basic -timeout 120m
=== RUN   TestAccAWSEIP_basic
=== PAUSE TestAccAWSEIP_basic
=== CONT  TestAccAWSEIP_basic
--- PASS: TestAccAWSEIP_basic (21.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.072s


$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_instance'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_instance -timeout 120m
=== RUN   TestAccAWSEIP_instance
=== PAUSE TestAccAWSEIP_instance
=== CONT  TestAccAWSEIP_instance
--- PASS: TestAccAWSEIP_instance (179.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	179.344s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_networkInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_networkInterface -timeout 120m
=== RUN   TestAccAWSEIP_networkInterface
=== PAUSE TestAccAWSEIP_networkInterface
=== CONT  TestAccAWSEIP_networkInterface
--- PASS: TestAccAWSEIP_networkInterface (41.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.810s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_twoEIPsOneNetworkInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_twoEIPsOneNetworkInterface -timeout 120m
=== RUN   TestAccAWSEIP_twoEIPsOneNetworkInterface
=== PAUSE TestAccAWSEIP_twoEIPsOneNetworkInterface
=== CONT  TestAccAWSEIP_twoEIPsOneNetworkInterface
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (45.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.611s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_associated_user_private_ip'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_associated_user_private_ip -timeout 120m
=== RUN   TestAccAWSEIP_associated_user_private_ip
=== PAUSE TestAccAWSEIP_associated_user_private_ip
=== CONT  TestAccAWSEIP_associated_user_private_ip
--- PASS: TestAccAWSEIP_associated_user_private_ip (135.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	135.592s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_Instance_Reassociate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_Instance_Reassociate -timeout 120m
=== RUN   TestAccAWSEIP_Instance_Reassociate
=== PAUSE TestAccAWSEIP_Instance_Reassociate
=== CONT  TestAccAWSEIP_Instance_Reassociate
--- PASS: TestAccAWSEIP_Instance_Reassociate (123.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	123.556s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_disappears -timeout 120m
=== RUN   TestAccAWSEIP_disappears
=== PAUSE TestAccAWSEIP_disappears
=== CONT  TestAccAWSEIP_disappears
--- PASS: TestAccAWSEIP_disappears (11.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.824s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_tags -timeout 120m
=== RUN   TestAccAWSEIP_tags
=== PAUSE TestAccAWSEIP_tags
=== CONT  TestAccAWSEIP_tags
--- PASS: TestAccAWSEIP_tags (25.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.641s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIPAssociate_notAssociated'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIPAssociate_notAssociated -timeout 120m
=== RUN   TestAccAWSEIPAssociate_notAssociated
=== PAUSE TestAccAWSEIPAssociate_notAssociated
=== CONT  TestAccAWSEIPAssociate_notAssociated
--- PASS: TestAccAWSEIPAssociate_notAssociated (162.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	162.881s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_PublicIpv4Pool_default'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_PublicIpv4Pool_default -timeout 120m
=== RUN   TestAccAWSEIP_PublicIpv4Pool_default
=== PAUSE TestAccAWSEIP_PublicIpv4Pool_default
=== CONT  TestAccAWSEIP_PublicIpv4Pool_default
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (14.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.595s

ewbankkit

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEIP_NetworkBorderGroup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEIP_NetworkBorderGroup -timeout 120m
=== RUN   TestAccAWSEIP_NetworkBorderGroup
=== PAUSE TestAccAWSEIP_NetworkBorderGroup
=== CONT  TestAccAWSEIP_NetworkBorderGroup
--- PASS: TestAccAWSEIP_NetworkBorderGroup (26.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.393s

cucxabong · 2020-09-18T10:28:11Z

Any update on this ?

DrFaust92

LGTM

--- PASS: TestAccAWSEIP_NetworkBorderGroup (61.10s)

cucxabong · 2020-10-26T15:03:10Z

think we could merge this @ewbankkit

ewbankkit

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEIP_NetworkBorderGroup\|TestAccAWSEIP_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSEIP_NetworkBorderGroup\|TestAccAWSEIP_basic -timeout 120m
=== RUN   TestAccAWSEIP_basic
=== PAUSE TestAccAWSEIP_basic
=== RUN   TestAccAWSEIP_NetworkBorderGroup
=== PAUSE TestAccAWSEIP_NetworkBorderGroup
=== CONT  TestAccAWSEIP_basic
=== CONT  TestAccAWSEIP_NetworkBorderGroup
--- PASS: TestAccAWSEIP_basic (23.94s)
--- PASS: TestAccAWSEIP_NetworkBorderGroup (26.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.352s

bflad

Looks good, thanks @drexler 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEIP_associated_user_private_ip (207.97s)
--- PASS: TestAccAWSEIP_basic (20.14s)
--- PASS: TestAccAWSEIP_disappears (12.47s)
--- PASS: TestAccAWSEIP_instance (106.47s)
--- PASS: TestAccAWSEIP_Instance_Reassociate (162.39s)
--- PASS: TestAccAWSEIP_NetworkBorderGroup (20.14s)
--- PASS: TestAccAWSEIP_networkInterface (89.36s)
--- PASS: TestAccAWSEIP_notAssociated (117.01s)
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (19.01s)
--- PASS: TestAccAWSEIP_tags_Ec2Classic (4.88s)
--- PASS: TestAccAWSEIP_tags_Vpc (27.91s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (88.20s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (2.45s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)

ghost · 2020-11-06T00:56:55Z

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-12-05T17:11:25Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

drexler added 3 commits July 2, 2020 07:17

feat: support NetworkBorderGroup parameter for aws_eip resource

e3c7c85

test: add cover test

0e54d1f

docs: update resource documentation

1f4ac63

drexler marked this pull request as ready for review July 2, 2020 11:36

drexler requested a review from a team July 2, 2020 11:36

ewbankkit reviewed Jul 2, 2020

View reviewed changes

Comment thread aws/resource_aws_eip_test.go Outdated

fixup! test: add cover test

294a1db

ewbankkit reviewed Jul 2, 2020

View reviewed changes

Comment thread aws/resource_aws_eip.go

breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 3, 2020

fixup! feat: support NetworkBorderGroup parameter for aws_eip resource

bcecc40

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:26

ewbankkit mentioned this pull request Aug 7, 2020

AWS Wavelength support #14518

Closed

7 tasks

ewbankkit reviewed Aug 7, 2020

View reviewed changes

ewbankkit requested review from DrFaust92 and removed request for a team August 7, 2020 19:52

DrFaust92 approved these changes Oct 23, 2020

View reviewed changes

bflad reviewed Oct 27, 2020

View reviewed changes

Comment thread aws/resource_aws_eip_test.go Outdated

Update aws/resource_aws_eip_test.go

04a6398

ewbankkit approved these changes Oct 27, 2020

View reviewed changes

bflad self-assigned this Nov 4, 2020

bflad added this to the v3.14.0 milestone Nov 4, 2020

bflad approved these changes Nov 5, 2020

View reviewed changes

bflad merged commit bdfcdf6 into hashicorp:master Nov 5, 2020

bflad added a commit that referenced this pull request Nov 5, 2020

Update CHANGELOG for #14028

1bfc27b

drexler deleted the eip-param branch November 6, 2020 01:22

ghost locked as resolved and limited conversation to collaborators Dec 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_eip - support NetworkBorderGroup attribute#14028

r/aws_eip - support NetworkBorderGroup attribute#14028
bflad merged 6 commits into
hashicorp:masterfrom
drexler:eip-param

drexler commented Jul 2, 2020

Uh oh!

Uh oh!

Uh oh!

drexler commented Jul 5, 2020

Uh oh!

ewbankkit left a comment

Uh oh!

cucxabong commented Sep 18, 2020

Uh oh!

DrFaust92 left a comment

Uh oh!

cucxabong commented Oct 26, 2020

Uh oh!

Uh oh!

ewbankkit left a comment

Uh oh!

bflad left a comment

Uh oh!

ghost commented Nov 6, 2020

Uh oh!

ghost commented Dec 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

drexler commented Jul 2, 2020

Community Note

Uh oh!

Uh oh!

Uh oh!

drexler commented Jul 5, 2020

Uh oh!

ewbankkit left a comment

Choose a reason for hiding this comment

Uh oh!

cucxabong commented Sep 18, 2020

Uh oh!

DrFaust92 left a comment

Choose a reason for hiding this comment

Uh oh!

cucxabong commented Oct 26, 2020

Uh oh!

Uh oh!

ewbankkit left a comment

Choose a reason for hiding this comment

Uh oh!

bflad left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 6, 2020

Uh oh!

ghost commented Dec 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants