resource/autoscaling_group: reintroduce changes made in #9478

[anGie44]

…from exported attributes list

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #3265
Reference #9478

Release note for CHANGELOG:

resource/autoscaling_group: reintroduce changes made in #9478; enable drift detection for target_group_arns and load_balancers

Output from acceptance testing:

--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (389.35s)

--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (44.38s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (51.23s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (72.06s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (78.50s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (85.45s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (91.89s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (97.87s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (109.13s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (42.31s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (44.36s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (66.41s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (44.55s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (163.88s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (45.58s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (181.92s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (53.01s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (151.65s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (203.54s)
--- PASS: TestAccAWSAutoScalingGroup_tags (204.92s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (109.52s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (44.78s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (81.30s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (41.66s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (72.72s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (46.69s)
--- PASS: TestAccAWSAutoScalingGroup_basic (259.97s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (262.49s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (265.15s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (135.15s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (295.39s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (259.13s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (320.66s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (135.33s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (377.59s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (401.63s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (673.21s)

--- PASS: TestAccAWSAutoscalingAttachment_elb (112.57s)
--- PASS: TestAccAWSAutoscalingAttachment_albTargetGroup (139.62s)

[bflad]

The changes for this are looking good so far -- a few little extra things here, since this can unexpectedly change the behavior for a few folks and why we backed this out previously:

• We will want to ensure the aws_autoscaling_attachment resource documentation notes that the aws_autoscaling_group resource will now require the use of ignore_changes if they are both used in the same Terraform configuration (in addition to adding a yellow box note, might be good to update the example)
• The aws_autoscaling_attachment resource test configurations likely will require the ignore_changes update to continue passing
• Can you also please add a section to the Version 3 upgrade guide?

Please reach out if you have any questions!

[anGie44]

@bflad, docs and tests updated and ready for review!

[bflad]

Looks great, just one overall suggestion about the example configurations 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAutoscalingAttachment_albTargetGroup (257.88s)
--- PASS: TestAccAWSAutoscalingAttachment_elb (136.01s)

--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (298.49s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (392.21s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (46.67s)
--- PASS: TestAccAWSAutoScalingGroup_basic (265.46s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (88.34s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (92.30s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (150.31s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (200.02s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (91.44s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (79.01s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (206.82s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (41.82s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (677.62s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (132.00s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (43.07s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (115.50s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (91.46s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (46.27s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (46.72s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (67.64s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (80.19s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (43.87s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (62.88s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (49.02s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (43.43s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (140.64s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (77.26s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (52.81s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (269.20s)
--- PASS: TestAccAWSAutoScalingGroup_tags (270.03s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (236.92s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (141.59s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (114.18s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (319.77s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (423.38s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (287.85s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (516.51s)

[anGie44]

Rebased to incorporate updates in upgrade guide

[ghost]

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!