r/aws_ssm_document - support VersionName parameter

[drexler]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14107

Release note for CHANGELOG:

Support VersionName parameter for aws_ssm_document resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMDocument'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMDocument -timeout 120m
=== RUN   TestAccAWSSSMDocument_basic
=== PAUSE TestAccAWSSSMDocument_basic
=== RUN   TestAccAWSSSMDocument_target_type
=== PAUSE TestAccAWSSSMDocument_target_type
=== RUN   TestAccAWSSSMDocument_version_name
=== PAUSE TestAccAWSSSMDocument_version_name
=== RUN   TestAccAWSSSMDocument_update
=== PAUSE TestAccAWSSSMDocument_update
=== RUN   TestAccAWSSSMDocument_permission_public
=== PAUSE TestAccAWSSSMDocument_permission_public
=== RUN   TestAccAWSSSMDocument_permission_private
=== PAUSE TestAccAWSSSMDocument_permission_private
=== RUN   TestAccAWSSSMDocument_permission_batching
=== PAUSE TestAccAWSSSMDocument_permission_batching
=== RUN   TestAccAWSSSMDocument_permission_change
=== PAUSE TestAccAWSSSMDocument_permission_change
=== RUN   TestAccAWSSSMDocument_params
=== PAUSE TestAccAWSSSMDocument_params
=== RUN   TestAccAWSSSMDocument_automation
=== PAUSE TestAccAWSSSMDocument_automation
=== RUN   TestAccAWSSSMDocument_package
=== PAUSE TestAccAWSSSMDocument_package
=== RUN   TestAccAWSSSMDocument_SchemaVersion_1
=== PAUSE TestAccAWSSSMDocument_SchemaVersion_1
=== RUN   TestAccAWSSSMDocument_session
=== PAUSE TestAccAWSSSMDocument_session
=== RUN   TestAccAWSSSMDocument_DocumentFormat_YAML
=== PAUSE TestAccAWSSSMDocument_DocumentFormat_YAML
=== RUN   TestAccAWSSSMDocument_Tags
=== PAUSE TestAccAWSSSMDocument_Tags
=== CONT  TestAccAWSSSMDocument_basic
=== CONT  TestAccAWSSSMDocument_params
=== CONT  TestAccAWSSSMDocument_Tags
=== CONT  TestAccAWSSSMDocument_DocumentFormat_YAML
=== CONT  TestAccAWSSSMDocument_session
=== CONT  TestAccAWSSSMDocument_SchemaVersion_1
=== CONT  TestAccAWSSSMDocument_package
=== CONT  TestAccAWSSSMDocument_automation
=== CONT  TestAccAWSSSMDocument_permission_public
=== CONT  TestAccAWSSSMDocument_permission_change
=== CONT  TestAccAWSSSMDocument_permission_batching
=== CONT  TestAccAWSSSMDocument_permission_private
=== CONT  TestAccAWSSSMDocument_version_name
=== CONT  TestAccAWSSSMDocument_target_type
=== CONT  TestAccAWSSSMDocument_update
--- PASS: TestAccAWSSSMDocument_session (29.82s)
--- PASS: TestAccAWSSSMDocument_permission_public (37.99s)
--- PASS: TestAccAWSSSMDocument_permission_private (44.34s)
--- PASS: TestAccAWSSSMDocument_permission_batching (47.99s)
--- PASS: TestAccAWSSSMDocument_params (51.48s)
--- PASS: TestAccAWSSSMDocument_automation (51.62s)
--- PASS: TestAccAWSSSMDocument_target_type (55.04s)
--- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (61.63s)
--- PASS: TestAccAWSSSMDocument_Tags (63.34s)
--- PASS: TestAccAWSSSMDocument_package (64.46s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (64.82s)
--- PASS: TestAccAWSSSMDocument_update (74.92s)
--- PASS: TestAccAWSSSMDocument_permission_change (76.45s)
--- PASS: TestAccAWSSSMDocument_version_name (86.55s)
--- PASS: TestAccAWSSSMDocument_basic (118.95s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       119.068s

...

[bflad]

Thank you for submitting this as well, @drexler. Overall looks pretty good, just some minor things to retrigger CI and will verify the UpdateDocument API behavior. 👍

[bflad]

Oddly enough, the UpdateDocument API operation also accepts VersionName, so going to verify its behavior on merge.

[bflad]

Thank you for this, @drexler 🚀 I was able to verify that the UpdateDocument VersionName support works as long as the content is updated as well. 👍

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSSMDocument_params (30.50s)
--- PASS: TestAccAWSSSMDocument_basic (32.24s)
--- PASS: TestAccAWSSSMDocument_session (32.29s)
--- PASS: TestAccAWSSSMDocument_permission_private (32.51s)
--- PASS: TestAccAWSSSMDocument_permission_batching (32.78s)
--- PASS: TestAccAWSSSMDocument_permission_public (32.80s)
--- PASS: TestAccAWSSSMDocument_automation (37.50s)
--- PASS: TestAccAWSSSMDocument_VersionName (46.97s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (46.99s)
--- PASS: TestAccAWSSSMDocument_target_type (48.06s)
--- PASS: TestAccAWSSSMDocument_update (48.17s)
--- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (48.20s)
--- PASS: TestAccAWSSSMDocument_Tags (57.02s)
--- PASS: TestAccAWSSSMDocument_permission_change (57.33s)
--- PASS: TestAccAWSSSMDocument_package (73.74s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSSSMDocument_basic (34.86s)
--- PASS: TestAccAWSSSMDocument_session (39.41s)
--- PASS: TestAccAWSSSMDocument_params (39.84s)
--- PASS: TestAccAWSSSMDocument_permission_private (40.26s)
--- PASS: TestAccAWSSSMDocument_permission_public (40.37s)
--- PASS: TestAccAWSSSMDocument_permission_batching (40.94s)
--- PASS: TestAccAWSSSMDocument_automation (52.65s)
--- PASS: TestAccAWSSSMDocument_target_type (54.33s)
--- PASS: TestAccAWSSSMDocument_update (55.65s)
--- PASS: TestAccAWSSSMDocument_DocumentFormat_YAML (55.72s)
--- PASS: TestAccAWSSSMDocument_VersionName (55.79s)
--- PASS: TestAccAWSSSMDocument_SchemaVersion_1 (55.96s)
--- PASS: TestAccAWSSSMDocument_Tags (66.39s)
--- PASS: TestAccAWSSSMDocument_permission_change (68.28s)
--- PASS: TestAccAWSSSMDocument_package (80.15s)

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!