d/aws_launch_configuration: Add 'ebs_block_device.no_device' attribute by ewbankkit · Pull Request #14583 · hashicorp/terraform-provider-aws

ewbankkit · 2020-08-11T21:23:03Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

data-source/aws_launch_configuration: Add `no_device` attribute to `ebs_block_device` block

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchConfigurationDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfigurationDataSource_ -timeout 120m
=== RUN   TestAccAWSLaunchConfigurationDataSource_basic
=== PAUSE TestAccAWSLaunchConfigurationDataSource_basic
=== RUN   TestAccAWSLaunchConfigurationDataSource_securityGroups
=== PAUSE TestAccAWSLaunchConfigurationDataSource_securityGroups
=== RUN   TestAccAWSLaunchConfigurationDataSource_ebsNoDevice
=== PAUSE TestAccAWSLaunchConfigurationDataSource_ebsNoDevice
=== CONT  TestAccAWSLaunchConfigurationDataSource_basic
=== CONT  TestAccAWSLaunchConfigurationDataSource_securityGroups
=== CONT  TestAccAWSLaunchConfigurationDataSource_ebsNoDevice
--- PASS: TestAccAWSLaunchConfigurationDataSource_ebsNoDevice (22.88s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (23.22s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (32.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.644s

…rce_ebsNoDevice'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchConfigurationDataSource_ebsNoDevice' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfigurationDataSource_ebsNoDevice -timeout 120m === RUN TestAccAWSLaunchConfigurationDataSource_ebsNoDevice === PAUSE TestAccAWSLaunchConfigurationDataSource_ebsNoDevice === CONT TestAccAWSLaunchConfigurationDataSource_ebsNoDevice panic: Invalid address to set: []string{"ebs_block_device", "0", "no_device"} goroutine 281 [running]: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc001aa1280, 0x669198b, 0x10, 0x527fee0, 0xc000d65f80, 0x0, 0xc001aa1280) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource_data.go:188 +0x388 github.com/terraform-providers/terraform-provider-aws/aws.readLCBlockDevices(0xc001aa1280, 0xc001b19ba0, 0xc0016c6518, 0x52814e0, 0xc000e65820) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_launch_configuration.go:617 +0xc3 github.com/terraform-providers/terraform-provider-aws/aws.dataSourceAwsLaunchConfigurationRead(0xc001aa1280, 0x5ab98c0, 0xc00080c000, 0xb0afa40, 0x6a9c1b0) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/aws/data_source_aws_launch_configuration.go:251 +0xa1d github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc000378e70, 0x75c4920, 0xc00007b500, 0xc001aa1280, 0x5ab98c0, 0xc00080c000, 0x0, 0x0, 0x0) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go:281 +0x88 github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0xc000378e70, 0x75c4920, 0xc00007b500, 0xc000e52720, 0x5ab98c0, 0xc00080c000, 0xc00080c000, 0xc000e52720, 0x0, 0x0) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource.go:489 +0xff github.com/hashicorp/terraform-plugin-sdk/v2/internal/helper/plugin.(*GRPCProviderServer).ReadDataSource(0xc0008e8080, 0x75c4920, 0xc00007b500, 0xc00007b4c0, 0xc0008e8080, 0xc0008e8090, 0x6a9c1a0) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/internal/helper/plugin/grpc_provider.go:1102 +0x4c5 github.com/hashicorp/terraform-plugin-sdk/v2/internal/tfplugin5._Provider_ReadDataSource_Handler.func1(0x75c4920, 0xc00007b500, 0x6401a40, 0xc00007b4c0, 0xc00007b500, 0x5c2fce0, 0xc00094e701, 0xc000e52400) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/internal/tfplugin5/tfplugin5.pb.go:3348 +0x86 github.com/hashicorp/terraform-plugin-sdk/v2/plugin.Serve.func3.1(0x75c49e0, 0xc001638570, 0x6401a40, 0xc00007b4c0, 0xc000e523e0, 0xc000e52400, 0xc00172cba0, 0x5094d8, 0x62bf4e0, 0xc001638570) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/plugin/serve.go:76 +0x87 github.com/hashicorp/terraform-plugin-sdk/v2/internal/tfplugin5._Provider_ReadDataSource_Handler(0x6531980, 0xc0008e8080, 0x75c49e0, 0xc001638570, 0xc00094e7e0, 0xc0008e83a0, 0x75c49e0, 0xc001638570, 0xc000dd4780, 0x179) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/internal/tfplugin5/tfplugin5.pb.go:3350 +0x14b google.golang.org/grpc.(*Server).processUnaryRPC(0xc000dba1c0, 0x75eb560, 0xc00140c000, 0xc001c01600, 0xc001c225d0, 0xb05c0b0, 0x0, 0x0, 0x0) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/google.golang.org/grpc/server.go:1171 +0x50a google.golang.org/grpc.(*Server).handleStream(0xc000dba1c0, 0x75eb560, 0xc00140c000, 0xc001c01600, 0x0) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/google.golang.org/grpc/server.go:1494 +0xccd google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc000eddec0, 0xc000dba1c0, 0x75eb560, 0xc00140c000, 0xc001c01600) /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/google.golang.org/grpc/server.go:834 +0xa1 created by google.golang.org/grpc.(*Server).serveStreams.func1 /home/kit/wrk/src/github.com/terraform-providers/terraform-provider-aws/vendor/google.golang.org/grpc/server.go:832 +0x204 FAIL github.com/terraform-providers/terraform-provider-aws/aws 9.129s FAIL GNUmakefile:26: recipe for target 'testacc' failed make: *** [testacc] Error 1

Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchConfigurationDataSource_ebsNoDevice' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfigurationDataSource_ebsNoDevice -timeout 120m === RUN TestAccAWSLaunchConfigurationDataSource_ebsNoDevice === PAUSE TestAccAWSLaunchConfigurationDataSource_ebsNoDevice === CONT TestAccAWSLaunchConfigurationDataSource_ebsNoDevice --- PASS: TestAccAWSLaunchConfigurationDataSource_ebsNoDevice (19.54s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 19.590s

ewbankkit · 2020-08-12T12:11:02Z

WIP as one of the other acceptance test cases is failing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchConfigurationDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfigurationDataSource_ -timeout 120m
=== RUN   TestAccAWSLaunchConfigurationDataSource_basic
=== PAUSE TestAccAWSLaunchConfigurationDataSource_basic
=== RUN   TestAccAWSLaunchConfigurationDataSource_securityGroups
=== PAUSE TestAccAWSLaunchConfigurationDataSource_securityGroups
=== RUN   TestAccAWSLaunchConfigurationDataSource_ebsNoDevice
=== PAUSE TestAccAWSLaunchConfigurationDataSource_ebsNoDevice
=== CONT  TestAccAWSLaunchConfigurationDataSource_basic
=== CONT  TestAccAWSLaunchConfigurationDataSource_ebsNoDevice
=== CONT  TestAccAWSLaunchConfigurationDataSource_securityGroups
=== CONT  TestAccAWSLaunchConfigurationDataSource_basic
    data_source_aws_launch_configuration_test.go:16: Check 6/8 error: data.aws_launch_configuration.foo: Attribute 'ebs_block_device.#' expected "1", got "2"
--- FAIL: TestAccAWSLaunchConfigurationDataSource_basic (12.34s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_ebsNoDevice (19.66s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (31.75s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	31.797s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1

Probably due to AMI ID changes introduced in #14147.

…rce_basic'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchConfigurationDataSource_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfigurationDataSource_basic -timeout 120m === RUN TestAccAWSLaunchConfigurationDataSource_basic === PAUSE TestAccAWSLaunchConfigurationDataSource_basic === CONT TestAccAWSLaunchConfigurationDataSource_basic --- PASS: TestAccAWSLaunchConfigurationDataSource_basic (19.27s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 19.317s

ewbankkit · 2020-08-12T12:32:05Z

Removed WIP. Test fixed.

bflad

Looks good, thanks @ewbankkit 🚀

Output from acceptance testing:

--- PASS: TestAccAWSLaunchConfigurationDataSource_ebsNoDevice (16.78s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (16.97s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (18.15s)

ghost · 2020-08-14T01:59:01Z

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-09-12T17:11:38Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit added 2 commits August 11, 2020 17:10

ewbankkit requested a review from a team August 11, 2020 21:23

ghost added size/S Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 11, 2020

Add documentation.

af28b88

ghost added the documentation Introduces or discusses updates to documentation. label Aug 11, 2020

ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Aug 11, 2020

ewbankkit changed the title ~~d/aws_launch_configuration: Add 'ebs_block_device.no_device' attribute~~ [WIP] d/aws_launch_configuration: Add 'ebs_block_device.no_device' attribute Aug 12, 2020

ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Aug 12, 2020

ewbankkit changed the title ~~[WIP] d/aws_launch_configuration: Add 'ebs_block_device.no_device' attribute~~ d/aws_launch_configuration: Add 'ebs_block_device.no_device' attribute Aug 12, 2020

bflad self-assigned this Aug 12, 2020

bflad added this to the v3.2.0 milestone Aug 12, 2020

bflad approved these changes Aug 13, 2020

View reviewed changes

bflad merged commit 8468412 into hashicorp:master Aug 13, 2020

bflad added a commit that referenced this pull request Aug 13, 2020

Update CHANGELOG for #14583

fc3a5f6

ewbankkit deleted the b-aws_launch_configuration-data-source-mismatched-schema branch August 13, 2020 14:27

ghost locked and limited conversation to collaborators Sep 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

d/aws_launch_configuration: Add 'ebs_block_device.no_device' attribute#14583

d/aws_launch_configuration: Add 'ebs_block_device.no_device' attribute#14583
bflad merged 4 commits into
hashicorp:masterfrom
ewbankkit:b-aws_launch_configuration-data-source-mismatched-schema

ewbankkit commented Aug 11, 2020 •

edited

Loading

Uh oh!

ewbankkit commented Aug 12, 2020 •

edited

Loading

Uh oh!

ewbankkit commented Aug 12, 2020

Uh oh!

bflad left a comment

Uh oh!

ghost commented Aug 14, 2020

Uh oh!

ghost commented Sep 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ewbankkit commented Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Uh oh!

ewbankkit commented Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ewbankkit commented Aug 12, 2020

Uh oh!

bflad left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Aug 14, 2020

Uh oh!

ghost commented Sep 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ewbankkit commented Aug 11, 2020 •

edited

Loading

ewbankkit commented Aug 12, 2020 •

edited

Loading