New resource: aws_cloudwatch_composite_alarm

[roberth-k]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12272

Release note for CHANGELOG:

FEATURES:
- **New Resource:** `aws_cloudwatch_composite_alarm`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsCloudWatchCompositeAlarm_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsCloudWatchCompositeAlarm_ -timeout 120m
--- PASS: TestAccAwsCloudWatchCompositeAlarm_disappears (19.78s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_basic (22.99s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_update (36.72s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       38.508s

[jvisker]

Any updates on this?

[jayy-mize]

any ETA on this feature being released?

welp, you guys are just making it easier to abandon terraform and move to AWS CDK. thanks for nothing! enjoy losing all that potential money from TF cloud and enterprise.

[mqchau]

@breathingdust Could you please take a look at this?

[breathingdust]

Hi all 👋 . Just letting you know this is on our list for our engineers to review and will feature in an upcoming release.

[anGie44]

Hi @roberth-k, thank you for this PR ! Off to a really great start 👍 Please find my comments here for review. Feel free to reach out with any questions/concerns!

Output of acceptance tests:

--- PASS: TestAccAwsCloudWatchCompositeAlarm_disappears (13.90s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_basic (37.54s)

[anGie44]

Hi @roberth-k 👋 checking in to see if you'll be able to address the changes requested here. Not a problem if you can't, we're happy to continue the work here and get it into an upcoming release, just let us know :)

[roberth-k]

Hi @anGie44! I'll get it sorted some time this week.

[anGie44]

sounds great, thanks @roberth-k 👍

[anGie44]

Hi @roberth-k 👋 Thank you again for this PR -- looked great overall! I've added a couple more acceptance tests for coverage to get this into our upcoming release.

Output of acceptance tests:

--- PASS: TestAccAwsCloudWatchCompositeAlarm_disappears (183.81s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_basic (231.57s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_description (306.49s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_updateAlarmRule (325.89s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_allActions (326.25s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_actionsEnabled (326.34s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_insufficientDataActions (375.92s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_alarmActions (376.01s)
--- PASS: TestAccAwsCloudWatchCompositeAlarm_okActions (377.01s)

[ghost]

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!