resource/aws_glue_workflow: Ensure max_concurrent_runs attribute is saved during import#15538
Conversation
…aved during import
The Terraform Plugin SDK version 2.0.4 upgrade fixed something with `ImportStateVerify` testing, which now catches these arguments were not properly being set during `Read`.
Previously:
```
=== CONT TestAccAWSGlueWorkflow_maxConcurrentRuns
TestAccAWSGlueWorkflow_maxConcurrentRuns: resource_aws_glue_workflow_test.go:82: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) {
}
(map[string]string) (len=1) {
(string) (len=19) "max_concurrent_runs": (string) (len=1) "1"
}
--- FAIL: TestAccAWSGlueWorkflow_maxConcurrentRuns (53.75s)
```
Output from acceptance testing:
```
--- PASS: TestAccAWSGlueWorkflow_basic (18.54s)
--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (18.56s)
--- PASS: TestAccAWSGlueWorkflow_Description (33.03s)
--- PASS: TestAccAWSGlueWorkflow_disappears (14.56s)
--- PASS: TestAccAWSGlueWorkflow_maxConcurrentRuns (50.47s)
--- PASS: TestAccAWSGlueWorkflow_Tags (48.23s)
```
gdavison
left a comment
There was a problem hiding this comment.
LGTM 🚀
--- PASS: TestAccAWSGlueWorkflow_disappears (17.78s)
--- PASS: TestAccAWSGlueWorkflow_basic (23.70s)
--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (24.00s)
--- PASS: TestAccAWSGlueWorkflow_Description (42.73s)
--- PASS: TestAccAWSGlueWorkflow_Tags (44.46s)
--- PASS: TestAccAWSGlueWorkflow_maxConcurrentRuns (46.71s)
|
This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Release note for CHANGELOG:
The Terraform Plugin SDK version 2.0.4 upgrade fixed something with
ImportStateVerifytesting, which now catches these arguments were not properly being set duringRead.Previously:
Output from acceptance testing: