[WIP] Check for ClusterNotFoundException when reading ECS service

[adam-tylr]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15917

Release note for CHANGELOG:

resource/aws_ecs_service: Handle ClusterNotFoundException when reading service (#15917)

WIP

I think this will fix the issue but I'm not sure how to write acceptance tests for it. Deleting the cluster doesn't make it immediately disappear from the account. The only way I know of to simulate the error without waiting for days is to update the state after manually deleting the service to point to an invalid cluster ARN. Then when terraform tries to read the service it will get the exception. I can't figure out how to do that in the tests. I tried messing with terraform.State but it seems like that's only there for reading

[bflad]

Hi @adam-tylr 👋 Thank you for submitting this fix. Given the API Reference and behavior you documented very well (thank you!), this fix seems valid and likely would not be pragmatic to try and replicate in an acceptance test. Given the fix type and good looking implementation, I'm going to merge this as-is. Thanks! 🚀

[ghost]

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!