r/aws_appmesh_virtual_gateway: Add connection pool by ewbankkit · Pull Request #16168 · hashicorp/terraform-provider-aws

ewbankkit · 2020-11-12T22:49:34Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #16097.

Release note for CHANGELOG:

resource/aws_appmesh_virtual_gateway: Add `listener.connection_pool` attribute

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualGateway'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualGateway -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/disappears
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/listenerConnectionPool
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/listenerTls
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/basic
--- PASS: TestAccAWSAppmesh_serial (248.80s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (248.80s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/disappears (13.51s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerConnectionPool (27.00s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (28.17s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerTls (71.33s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/logging (27.06s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tags (39.05s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (27.25s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/basic (15.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	248.882s

… ExactlyOneOf.

…ute. Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualGateway/listenerConnectionPool' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualGateway/listenerConnectionPool -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/VirtualGateway === RUN TestAccAWSAppmesh_serial/VirtualGateway/listenerConnectionPool --- PASS: TestAccAWSAppmesh_serial (26.75s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (26.75s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerConnectionPool (26.75s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 26.797s

Acceptance test output: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualGateway -timeout 120m === RUN TestAccAWSAppmesh_serial === RUN TestAccAWSAppmesh_serial/VirtualGateway === RUN TestAccAWSAppmesh_serial/VirtualGateway/disappears === RUN TestAccAWSAppmesh_serial/VirtualGateway/listenerConnectionPool === RUN TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks === RUN TestAccAWSAppmesh_serial/VirtualGateway/listenerTls === RUN TestAccAWSAppmesh_serial/VirtualGateway/logging === RUN TestAccAWSAppmesh_serial/VirtualGateway/tags === RUN TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults === RUN TestAccAWSAppmesh_serial/VirtualGateway/basic --- PASS: TestAccAWSAppmesh_serial (248.80s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (248.80s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/disappears (13.51s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerConnectionPool (27.00s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (28.17s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerTls (71.33s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/logging (27.06s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tags (39.05s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (27.25s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/basic (15.42s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 248.882s

DrFaust92

LGTM

--- PASS: TestAccAWSAppmesh_serial (696.88s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (696.88s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/disappears (37.93s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerConnectionPool (84.01s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (75.60s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerTls (190.49s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/logging (84.05s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tags (110.87s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (72.07s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/basic (41.86s)

breathingdust · 2020-12-01T18:39:59Z

LGTM 🚀 Thanks @ewbankkit

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualGateway'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualGateway -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/listenerConnectionPool
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/listenerTls
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/disappears
--- PASS: TestAccAWSAppmesh_serial (219.02s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (219.02s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerConnectionPool (25.60s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (24.13s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerTls (60.28s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/logging (24.89s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tags (32.60s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (25.14s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/basic (14.32s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/disappears (12.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	220.984s

ghost · 2020-12-01T22:34:17Z

This has been released in version 3.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2021-01-01T17:11:47Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit added 4 commits November 12, 2020 17:08

r/aws_appmesh_virtual_gateway: Replace ConflictsWith constraints with…

f0ebad5

… ExactlyOneOf.

r/aws_appmesh_virtual_gateway: Add 'listener.connection_pool' attribute.

0829ba8

ewbankkit requested a review from a team as a code owner November 12, 2020 22:49

ghost added size/XL Managed by automation to categorize the size of a PR. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 12, 2020

DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 14, 2020

DrFaust92 approved these changes Nov 14, 2020

View reviewed changes

breathingdust added this to the v3.19.0 milestone Dec 1, 2020

breathingdust merged commit 0627b91 into hashicorp:master Dec 1, 2020

breathingdust added a commit that referenced this pull request Dec 1, 2020

Update CHANGELOG.md for #16168

5d3d719

ewbankkit deleted the f-aws_appmesh_virtual_gateway-connection_pool branch December 1, 2020 18:59

ghost locked as resolved and limited conversation to collaborators Jan 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_appmesh_virtual_gateway: Add connection pool#16168

r/aws_appmesh_virtual_gateway: Add connection pool#16168
breathingdust merged 4 commits into
hashicorp:masterfrom
ewbankkit:f-aws_appmesh_virtual_gateway-connection_pool

ewbankkit commented Nov 12, 2020

Uh oh!

DrFaust92 left a comment

Uh oh!

breathingdust commented Dec 1, 2020

Uh oh!

ghost commented Dec 1, 2020

Uh oh!

ghost commented Jan 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ewbankkit commented Nov 12, 2020

Community Note

Uh oh!

DrFaust92 left a comment

Choose a reason for hiding this comment

Uh oh!

breathingdust commented Dec 1, 2020

Uh oh!

ghost commented Dec 1, 2020

Uh oh!

ghost commented Jan 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants