resource/aws_db_proxy_default_target_group: Make connection_pool_config Optional#16303
Conversation
anGie44
left a comment
There was a problem hiding this comment.
LGTM 🚀
output of added acceptance test:
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_EmptyConnectionPoolConfig (689.41s)
| testAccCheckAWSDBProxyTargetGroupExists(resourceName, &dbProxyTargetGroup), | ||
| testAccMatchResourceAttrRegionalARN(resourceName, "arn", "rds", regexp.MustCompile(`target-group:.+`)), | ||
| resource.TestCheckResourceAttr(resourceName, "connection_pool_config.#", "1"), | ||
| resource.TestCheckTypeSetElemNestedAttrs(resourceName, "connection_pool_config.*", map[string]string{ |
There was a problem hiding this comment.
cool! never thought to use this method for Lists as well
|
This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
The documentation for
aws_db_proxy_default_target_groupstates thatconnection_pool_configis optional and the API does not require it.Closes #16285
Release note for CHANGELOG:
Output from acceptance testing: