r/backup_global_settings - add new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16343

Release note for CHANGELOG:

resource_aws_backup_global_settings - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsBackupGlobalSettings_basic'
--- PASS: TestAccAwsBackupGlobalSettings_basic (104.31s)

[ewbankkit]

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN   TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT  TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (31.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.167s

[bobziuchkovski]

Curious if this one is going to be merged soon?

[ewbankkit]

@DrFaust92 Is this ready for re-review?

[DrFaust92]

@ewbankkit Yes! thank you 👍

[ewbankkit]

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN   TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT  TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (29.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.997s

[breathingdust]

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN   TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT  TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (30.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.249s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN   TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT  TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (20.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.499s

[ghost]

This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!