r/backup_plan - retry on delete + validations

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10414

Release note for CHANGELOG:

resource_aws_backup_plan - retry delete if selections are still attached
resource_aws_backup_plan - add plan time validations for `rule.rule_name`, `rule.target_vault_name` , `rule.lifecycle.delete_after`, `rule.copy_action.lifecycle.delete_after`, `advanced_backup_setting.resource_type 

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsBackupPlan_'
--- PASS: TestAccAwsBackupPlan_basic (51.36s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle (130.37s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_SameRegion (139.68s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (209.53s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (176.58s)
--- PASS: TestAccAwsBackupPlan_AdvancedBackupSetting (94.81s)
--- PASS: TestAccAwsBackupPlan_disappears (37.81s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion (47.25s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_Multiple (47.56s)
--- PASS: TestAccAwsBackupPlan_withRules (169.26s)
--- PASS: TestAccAwsBackupPlan_withTags (123.17s)

[ewbankkit]

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_ -timeout 120m
=== RUN   TestAccAwsBackupPlan_basic
=== PAUSE TestAccAwsBackupPlan_basic
=== RUN   TestAccAwsBackupPlan_withTags
=== PAUSE TestAccAwsBackupPlan_withTags
=== RUN   TestAccAwsBackupPlan_withRules
=== PAUSE TestAccAwsBackupPlan_withRules
=== RUN   TestAccAwsBackupPlan_withLifecycle
=== PAUSE TestAccAwsBackupPlan_withLifecycle
=== RUN   TestAccAwsBackupPlan_withRecoveryPointTags
=== PAUSE TestAccAwsBackupPlan_withRecoveryPointTags
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== RUN   TestAccAwsBackupPlan_AdvancedBackupSetting
=== PAUSE TestAccAwsBackupPlan_AdvancedBackupSetting
=== RUN   TestAccAwsBackupPlan_disappears
=== PAUSE TestAccAwsBackupPlan_disappears
=== CONT  TestAccAwsBackupPlan_basic
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== CONT  TestAccAwsBackupPlan_disappears
=== CONT  TestAccAwsBackupPlan_AdvancedBackupSetting
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== CONT  TestAccAwsBackupPlan_withLifecycle
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== CONT  TestAccAwsBackupPlan_withRecoveryPointTags
=== CONT  TestAccAwsBackupPlan_withRules
=== CONT  TestAccAwsBackupPlan_withTags
--- PASS: TestAccAwsBackupPlan_disappears (35.91s)
--- PASS: TestAccAwsBackupPlan_basic (42.04s)
--- PASS: TestAccAwsBackupPlan_AdvancedBackupSetting (42.70s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_Multiple (42.82s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion (44.20s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (72.50s)
--- PASS: TestAccAwsBackupPlan_withRules (73.04s)
--- PASS: TestAccAwsBackupPlan_withTags (76.57s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle (77.55s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_SameRegion (78.34s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (88.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	88.418s

[bflad]

Otherwise looking good

[bflad]

Looks good, thank you @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAwsBackupPlan_disappears (28.69s)
--- PASS: TestAccAwsBackupPlan_basic (32.26s)
--- PASS: TestAccAwsBackupPlan_AdvancedBackupSetting (32.54s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_Multiple (32.98s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion (41.01s)
--- PASS: TestAccAwsBackupPlan_withTags (58.71s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (58.79s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_SameRegion (58.91s)
--- PASS: TestAccAwsBackupPlan_withRules (59.84s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle (60.10s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (65.80s)

[ghost]

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!