increased max retention period for kinesis stream to 8760

[with-joy]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #16179

Release note for CHANGELOG:

resource/aws_kinesis_stream: Added support for retention period up to 8760 hours.

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSKinesisStream_retentionPeriod'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisStream_retentionPeriod -timeout 120m
=== RUN   TestAccAWSKinesisStream_retentionPeriod
=== PAUSE TestAccAWSKinesisStream_retentionPeriod
=== CONT  TestAccAWSKinesisStream_retentionPeriod
--- PASS: TestAccAWSKinesisStream_retentionPeriod (157.29s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       159.160s

...

[ewbankkit]

@with-joy Thanks for the contribution.
Could you please also update the documentation in website/docs/r/kinesis_stream.html.markdown.

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSKinesisStream_retentionPeriod'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisStream_retentionPeriod -timeout 120m
=== RUN   TestAccAWSKinesisStream_retentionPeriod
=== PAUSE TestAccAWSKinesisStream_retentionPeriod
=== CONT  TestAccAWSKinesisStream_retentionPeriod
--- PASS: TestAccAWSKinesisStream_retentionPeriod (96.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	96.975s

[with-joy]

@ewbankkit : ah apologies missed that. Have updated the documentation now.

[ewbankkit]

LGTM.

[with-joy]

@ewbankkit can this be merged in?

[anGie44]

Thanks again for this PR @with-joy 🚀

[ghost]

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!