aws_launch_template: gp3 volume scalable throughput by ewbankkit · Pull Request #16649 · hashicorp/terraform-provider-aws

ewbankkit · 2020-12-08T18:20:17Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16514.

Release note for CHANGELOG:

resource/aws_launch_template: Support `volume_type` value of `gp3`. Add `throughput` attribute to `block_device_mappings.ebs` configuration block.
data-source/aws_launch_template: Add `throughput` attribute to `block_device_mappings.ebs` configuration block.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 (35.81s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (35.94s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (68.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.946s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplateDataSource_ -timeout 120m
=== RUN   TestAccAWSLaunchTemplateDataSource_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_tags
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_tags
=== RUN   TestAccAWSLaunchTemplateDataSource_metadataOptions
=== PAUSE TestAccAWSLaunchTemplateDataSource_metadataOptions
=== RUN   TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== RUN   TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== PAUSE TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== RUN   TestAccAWSLaunchTemplateDataSource_NonExistent
=== PAUSE TestAccAWSLaunchTemplateDataSource_NonExistent
=== CONT  TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== CONT  TestAccAWSLaunchTemplateDataSource_NonExistent
=== CONT  TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_metadataOptions
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_tags
=== CONT  TestAccAWSLaunchTemplateDataSource_basic
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (4.66s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (22.81s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (23.91s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (24.09s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (25.09s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (47.45s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (48.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.749s

…ppings.ebs` configuration block. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS -timeout 120m === RUN TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS === PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS === RUN TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination === PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination === RUN TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 === PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 === CONT TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS === CONT TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 === CONT TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination --- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 (35.81s) --- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (35.94s) --- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (68.82s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 68.946s

…ppings.ebs` configuration block. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplateDataSource_ -timeout 120m === RUN TestAccAWSLaunchTemplateDataSource_basic === PAUSE TestAccAWSLaunchTemplateDataSource_basic === RUN TestAccAWSLaunchTemplateDataSource_filter_basic === PAUSE TestAccAWSLaunchTemplateDataSource_filter_basic === RUN TestAccAWSLaunchTemplateDataSource_filter_tags === PAUSE TestAccAWSLaunchTemplateDataSource_filter_tags === RUN TestAccAWSLaunchTemplateDataSource_metadataOptions === PAUSE TestAccAWSLaunchTemplateDataSource_metadataOptions === RUN TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress === PAUSE TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress === RUN TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination === PAUSE TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination === RUN TestAccAWSLaunchTemplateDataSource_NonExistent === PAUSE TestAccAWSLaunchTemplateDataSource_NonExistent === CONT TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress === CONT TestAccAWSLaunchTemplateDataSource_NonExistent === CONT TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination === CONT TestAccAWSLaunchTemplateDataSource_filter_basic === CONT TestAccAWSLaunchTemplateDataSource_metadataOptions === CONT TestAccAWSLaunchTemplateDataSource_filter_tags === CONT TestAccAWSLaunchTemplateDataSource_basic --- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (4.66s) --- PASS: TestAccAWSLaunchTemplateDataSource_basic (22.81s) --- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (23.91s) --- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (24.09s) --- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (25.09s) --- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (47.45s) --- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (48.65s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 48.749s

bflad

Looks great, thanks @ewbankkit 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSLaunchTemplate_associateCarrierIPAddress (155.51s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (155.61s)
--- PASS: TestAccAWSLaunchTemplate_basic (43.82s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (91.03s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (119.93s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 (76.34s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (37.62s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (42.31s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (33.39s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (39.29s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (39.41s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (38.58s)
--- PASS: TestAccAWSLaunchTemplate_data (39.47s)
--- PASS: TestAccAWSLaunchTemplate_defaultVersion (98.41s)
--- PASS: TestAccAWSLaunchTemplate_description (70.20s)
--- PASS: TestAccAWSLaunchTemplate_disappears (29.58s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (119.62s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (70.71s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (80.12s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (32.23s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (89.47s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (48.40s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (39.25s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (90.94s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (38.50s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (39.11s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (91.49s)
--- PASS: TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination (116.56s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (74.66s)
--- PASS: TestAccAWSLaunchTemplate_tags (69.34s)
--- PASS: TestAccAWSLaunchTemplate_update (132.54s)
--- PASS: TestAccAWSLaunchTemplate_updateDefaultVersion (115.53s)

--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (96.99s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (70.19s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (32.26s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (43.05s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (42.29s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (45.24s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (100.00s)
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (6.69s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSLaunchTemplate_associateCarrierIPAddress (117.32s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (117.09s)
--- PASS: TestAccAWSLaunchTemplate_basic (38.56s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (69.50s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (138.59s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 (91.71s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (52.68s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (54.79s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (24.35s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (27.41s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (38.19s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (35.93s)
--- PASS: TestAccAWSLaunchTemplate_data (53.25s)
--- PASS: TestAccAWSLaunchTemplate_defaultVersion (118.63s)
--- PASS: TestAccAWSLaunchTemplate_description (89.00s)
--- PASS: TestAccAWSLaunchTemplate_disappears (34.02s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (156.80s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (84.76s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (119.48s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (41.54s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (128.24s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (36.52s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (51.43s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (72.73s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (51.90s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (53.29s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (73.66s)
--- PASS: TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination (139.41s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (94.17s)
--- PASS: TestAccAWSLaunchTemplate_tags (90.90s)
--- PASS: TestAccAWSLaunchTemplate_update (129.93s)
--- PASS: TestAccAWSLaunchTemplate_updateDefaultVersion (140.38s)

--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (97.95s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (97.97s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (46.88s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (23.72s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (26.75s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (47.53s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (100.84s)
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (7.40s)

ghost · 2020-12-11T17:09:20Z

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

jonjohnston · 2020-12-15T20:44:41Z

Spelling error:
the parameter should be throughput but it is thoughput

ghost · 2021-01-10T17:10:01Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit requested a review from a team as a code owner December 8, 2020 18:20

ewbankkit mentioned this pull request Dec 8, 2020

EBS gp3 volume scalable throughput #16514

Closed

ewbankkit changed the title ~~[WIP] aws_launch_template: gp3 volume scalable throughput~~ aws_launch_template: gp3 volume scalable throughput Dec 8, 2020

bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 11, 2020

bflad self-assigned this Dec 11, 2020

bflad added this to the v3.21.0 milestone Dec 11, 2020

bflad approved these changes Dec 11, 2020

View reviewed changes

bflad merged commit 755de69 into hashicorp:master Dec 11, 2020

bflad added a commit that referenced this pull request Dec 11, 2020

Update CHANGELOG for #16649

120b944

ewbankkit deleted the f-aws_launch_template-gp3-throughput branch December 11, 2020 15:43

ghost locked as resolved and limited conversation to collaborators Jan 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

aws_launch_template: gp3 volume scalable throughput#16649

aws_launch_template: gp3 volume scalable throughput#16649
bflad merged 2 commits into
hashicorp:masterfrom
ewbankkit:f-aws_launch_template-gp3-throughput

ewbankkit commented Dec 8, 2020 •

edited

Loading

Uh oh!

bflad left a comment

Uh oh!

ghost commented Dec 11, 2020

Uh oh!

jonjohnston commented Dec 15, 2020

Uh oh!

ghost commented Jan 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ewbankkit commented Dec 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Uh oh!

bflad left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Dec 11, 2020

Uh oh!

jonjohnston commented Dec 15, 2020

Uh oh!

ghost commented Jan 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ewbankkit commented Dec 8, 2020 •

edited

Loading