feature: Add working_directory to ImageBuilder#16947
Conversation
ghost
added
size/XS
github-actions
Bot
added
the
needs-triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @schabert 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
bflad
added
enhancement
| }] | ||
| schemaVersion = 1.0 | ||
| }) | ||
| working_directory = "/tmp" |
There was a problem hiding this comment.
Per the Contributing Guide, it is preferred to have new optional arguments in new, separate acceptance tests. Will followup these commits adding a resource test and refactoring this data source test.
| Type: schema.TypeString, | ||
| Computed: true, | ||
| }, | ||
| "working_directory": { |
There was a problem hiding this comment.
This new attribute needs documentation added in websites/docs/d/imagebuilder_image_recipe.html.markdown -- will followup on merge.
Reference: #16947 (review) Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderImageRecipe_disappears (31.42s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (34.85s) --- PASS: TestAccAwsImageBuilderImageRecipe_basic (35.02s) --- PASS: TestAccAwsImageBuilderImageRecipe_Description (37.85s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (38.14s) --- PASS: TestAccAwsImageBuilderImageRecipe_WorkingDirectory (38.17s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (38.18s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (38.24s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (38.32s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (38.39s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (38.44s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (38.44s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (39.35s) --- PASS: TestAccAwsImageBuilderImageRecipe_Component (39.39s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (48.07s) --- PASS: TestAccAwsImageBuilderImageRecipe_Tags (64.35s) --- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (27.89s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderImageRecipe_disappears (37.78s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (40.06s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (40.46s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (40.52s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (40.68s) --- PASS: TestAccAwsImageBuilderImageRecipe_basic (41.90s) --- PASS: TestAccAwsImageBuilderImageRecipe_Description (42.30s) --- PASS: TestAccAwsImageBuilderImageRecipe_WorkingDirectory (42.46s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (42.62s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (42.64s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (42.82s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (43.29s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (43.30s) --- PASS: TestAccAwsImageBuilderImageRecipe_Component (44.64s) --- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (49.57s) --- PASS: TestAccAwsImageBuilderImageRecipe_Tags (73.70s) --- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (30.79s) ```
|
This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
2 participants
Community Note
Closes #16946
Release note for CHANGELOG:
Output from acceptance testing: