Skip to content

r/codebuild_report_group - Allow deleting reports for report group delete#17338

Merged
bflad merged 9 commits into
hashicorp:mainfrom
DrFaust92:r/codebuild_wait_for_delete
Feb 11, 2021
Merged

r/codebuild_report_group - Allow deleting reports for report group delete#17338
bflad merged 9 commits into
hashicorp:mainfrom
DrFaust92:r/codebuild_wait_for_delete

Conversation

@DrFaust92

@DrFaust92 DrFaust92 commented Jan 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17290

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeBuildReportGroup_'
--- PASS: TestAccAWSCodeBuildReportGroup_disappears (27.56s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (36.17s)
--- PASS: TestAccAWSCodeBuildReportGroup_deleteReports (36.49s)
--- PASS: TestAccAWSCodeBuildReportGroup_tags (84.09s)
--- PASS: TestAccAWSCodeBuildReportGroup_export_s3 (123.29s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner January 28, 2021 19:13
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 28, 2021
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. labels Jan 28, 2021
@DrFaust92 DrFaust92 marked this pull request as draft January 28, 2021 19:16
bflad
bflad reviewed Jan 28, 2021
View reviewed changes
Comment thread aws/internal/service/codebuild/finder/finder.go Outdated
@DrFaust92 DrFaust92 changed the title r/codebuild_report_group - wait for delete r/codebuild_report_group - Allow deleting reports for report group delete Jan 28, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 28, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review January 28, 2021 20:08
@DrFaust92 DrFaust92 requested a review from bflad January 28, 2021 20:12
@bflad bflad self-assigned this Feb 11, 2021
bflad
bflad reviewed Feb 11, 2021
View reviewed changes

@bflad bflad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just will run the testing now

Comment thread .changelog/17338.txt Outdated
Comment thread aws/resource_aws_codebuild_report_group.go Outdated
Comment thread aws/resource_aws_codebuild_report_group_test.go
r := resourceAwsCodeBuildReportGroup()
d := r.Data(nil)
d.SetId(id)
d.Set("delete_reports", true)

@bflad bflad Feb 11, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

bflad
bflad reviewed Feb 11, 2021
View reviewed changes
Comment thread aws/resource_aws_codebuild_report_group_test.go Outdated
bflad
bflad approved these changes Feb 11, 2021
View reviewed changes

@bflad bflad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSCodeBuildReportGroup_disappears (10.64s)
--- PASS: TestAccAWSCodeBuildReportGroup_deleteReports (13.91s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (14.42s)
--- PASS: TestAccAWSCodeBuildReportGroup_tags (30.94s)
--- PASS: TestAccAWSCodeBuildReportGroup_export_s3 (46.32s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSCodeBuildReportGroup_disappears (14.58s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (19.24s)
--- PASS: TestAccAWSCodeBuildReportGroup_deleteReports (19.27s)
--- PASS: TestAccAWSCodeBuildReportGroup_tags (44.22s)
--- PASS: TestAccAWSCodeBuildReportGroup_export_s3 (50.66s)

@bflad bflad merged commit af77d84 into hashicorp:main Feb 11, 2021
@github-actions github-actions Bot added this to the v3.28.0 milestone Feb 11, 2021
@ghost

ghost commented Feb 12, 2021

Copy link
Copy Markdown

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost

ghost commented Mar 14, 2021

Copy link
Copy Markdown

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
@DrFaust92 DrFaust92 deleted the r/codebuild_wait_for_delete branch April 15, 2021 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bflad bflad bflad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bflad bflad

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v3.28.0

Development

Successfully merging this pull request may close these issues.

aws_codebuild_report_group needs time to delete previously generated reports, fails terraform apply

2 participants

@DrFaust92 @bflad
⚡