r/glue_catalog_database - Add sweeper + use catalog_id when deleting#17489
Merged
breathingdust merged 2 commits intoFeb 10, 2021
Merged
Conversation
ewbankkit
approved these changes
Feb 7, 2021
ewbankkit
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogDatabase_ -timeout 120m
=== RUN TestAccAWSGlueCatalogDatabase_full
=== PAUSE TestAccAWSGlueCatalogDatabase_full
=== RUN TestAccAWSGlueCatalogDatabase_disappears
=== PAUSE TestAccAWSGlueCatalogDatabase_disappears
=== CONT TestAccAWSGlueCatalogDatabase_full
=== CONT TestAccAWSGlueCatalogDatabase_disappears
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (10.09s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (33.13s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 33.221s
Member
|
LGTM 🚀 Thanks @DrFaust92! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogDatabase_ -timeout 120m
go: downloading github.com/hashicorp/go-cleanhttp v0.5.2
=== RUN TestAccAWSGlueCatalogDatabase_full
=== PAUSE TestAccAWSGlueCatalogDatabase_full
=== RUN TestAccAWSGlueCatalogDatabase_disappears
=== PAUSE TestAccAWSGlueCatalogDatabase_disappears
=== CONT TestAccAWSGlueCatalogDatabase_full
=== CONT TestAccAWSGlueCatalogDatabase_disappears
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (9.92s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (31.36s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 33.181s |
|
This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Output from acceptance testing: