Skip to content

Order bootstrap brokers from msk#17579

Merged
gdavison merged 2 commits into
hashicorp:mainfrom
aarya123:fixBrokers
Mar 3, 2021
Merged

Order bootstrap brokers from msk#17579
gdavison merged 2 commits into
hashicorp:mainfrom
aarya123:fixBrokers

Conversation

@aarya123

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #13488

Output from acceptance testing:

=== RUN   TestAccMskClusterDataSource_SortBrokers
--- PASS: TestAccMskClusterDataSource_SortBrokers (0.00s)
PASS

=== RUN   TestAccMskClusterReource_SortBrokers
--- PASS: TestAccMskClusterReource_SortBrokers (0.00s)
PASS

@aarya123 aarya123 requested a review from a team as a code owner February 12, 2021 00:21
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/kafka Issues and PRs that pertain to the kafka service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 12, 2021
@github-actions github-actions Bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 12, 2021

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @aarya123 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@gdavison gdavison self-assigned this Feb 26, 2021

@gdavison gdavison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @aarya123, it's a great start. I've made some updates to the acceptance testing and I've made all of the bootstrap brokers and the Zookeeper connection sorted.

gdavison added a commit that referenced this pull request Mar 3, 2021
@gdavison gdavison merged commit 77caafb into hashicorp:main Mar 3, 2021
@github-actions github-actions Bot added this to the v3.31.0 milestone Mar 3, 2021
@aarya123 aarya123 deleted the fixBrokers branch March 3, 2021 20:41
@aarya123

aarya123 commented Mar 3, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for getting this merged in! :)

@ghost

ghost commented Mar 5, 2021

Copy link
Copy Markdown

This has been released in version 3.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost

ghost commented Apr 3, 2021

Copy link
Copy Markdown

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

service/kafka Issues and PRs that pertain to the kafka service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws_msk_cluster.bootstrap_brokers has nondeterministic order

3 participants