Skip to content

Commit 2c93a2c

Browse files
authored
Remove unnecessary isinstances (python#20670)
Fixes python#20665 Unfortunately, to properly solve this problem (have mypy point these out) we need negation types, I think. See python#20668.
1 parent 0c2430f commit 2c93a2c

2 files changed

Lines changed: 0 additions & 6 deletions

File tree

mypyc/analysis/ircheck.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,8 +295,6 @@ def visit_load_literal(self, op: LoadLiteral) -> None:
295295
expected_type = "builtins.str"
296296
elif isinstance(op.value, bytes):
297297
expected_type = "builtins.bytes"
298-
elif isinstance(op.value, bool):
299-
expected_type = "builtins.object"
300298
elif isinstance(op.value, float):
301299
expected_type = "builtins.float"
302300
elif isinstance(op.value, complex):

mypyc/test/test_serialization.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,6 @@ def assert_blobs_same(x: Any, y: Any, trail: tuple[Any, ...]) -> None:
5555
for (xk, xv), (yk, yv) in zip(x.items(), y.items()):
5656
assert_blobs_same(xk, yk, trail + ("keys",))
5757
assert_blobs_same(xv, yv, trail + (xk,))
58-
elif isinstance(x, dict):
59-
assert x.keys() == y.keys(), f"Keys mismatch at {trail}"
60-
for k in x.keys():
61-
assert_blobs_same(x[k], y[k], trail + (k,))
6258
elif isinstance(x, Iterable) and not isinstance(x, (str, set)):
6359
# Special case iterables to generate better assert error messages.
6460
# We can't use this for sets since the ordering is unpredictable,

0 commit comments

Comments
 (0)