Commit d87b5d7
committed
Remove outdated Django version warning
Since:
- the version check was pretty broken (only matches against
that exact requirements file version syntax, plus doesn't
check unpinned but still outdated version etc)
- it only warned for Django 1.x, when there are lots of other
EOL Django versions since then
- it feels inconsistent for us to warn about one framework being
EOL when there are lots of other packages and frameworks out
there that should also be kept up to date too -- that's best handled
by services like Dependabot security alerts etc
If at such time in the future our Django collectstatic feature requires a
specific version of Django, any version checking/warning should occur
as part of that feature.
GUS-W-11593026.1 parent 5f896a4 commit d87b5d7
File tree
5 files changed
+1
-38
lines changed- bin/steps
- spec
- fixtures
- requirements_django_1.11
- requirements_django_2.1
- hatchet
5 files changed
+1
-38
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | 32 | | |
41 | 33 | | |
42 | 34 | | |
| |||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | 6 | | |
34 | 7 | | |
35 | 8 | | |
| |||
0 commit comments