Skip to content

Commit e8dbf8a

Browse files
committed
Remove Mercurial VCS test (#1362)
Since: - The test is currently failing due to https://www.mercurial-scm.org being down, and there aren't many/any other decent testcase alternatives, since so few projects use Mercurial these days (and we also need a testcase that's quick to install and doesn't need additional system libs). - All the test is really testing is that (a) the Mercurial binary is installed in the stack image, (b) that we haven't messed up the `PATH` passed to pip, (c) that Pip doesn't have a regression with Mercurial VCS support. However (a) isn't really a concern of this buildpack, (b) is still tested via the Git testcase, and (c) is unlikely/really an upstream concern (it's not viable/a good use of our time to try and replicate pip's test suite ourselves). GUS-W-11716181.
1 parent 70ec997 commit e8dbf8a

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# This relies upon the VCS binaries from the stack image.
2+
git+https://github.com/certifi/python-certifi

spec/fixtures/requirements_vcs/requirements.txt

Lines changed: 0 additions & 3 deletions
This file was deleted.

spec/hatchet/pip_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@
8181
include_examples 'installs successfully using pip'
8282
end
8383

84-
context 'when requirements.txt contains Git/Mercurial requirements URLs' do
85-
let(:app) { Hatchet::Runner.new('spec/fixtures/requirements_vcs') }
84+
context 'when requirements.txt contains Git requirements URLs' do
85+
let(:app) { Hatchet::Runner.new('spec/fixtures/requirements_git') }
8686

8787
include_examples 'installs successfully using pip'
8888
end

0 commit comments

Comments
 (0)