fix(external_link): noopenner should be noopener (#5729)

stevenjoezhang · web-flow · commit 1fd997c3ad77 · 2026-01-03T14:03:50.000+08:00
* fix(external_link): noopenner should be noopener

* fix(external_link): update tests
diff --git a/lib/plugins/filter/after_post_render/external_link.ts b/lib/plugins/filter/after_post_render/external_link.ts
@@ -23,7 +23,7 @@ function externalLinkFilter(this: Hexo, data: RenderData): void {
 
     if (rRelAttr.test(str)) {
       str = str.replace(rRelStrAttr, (relStr, rel) => {
-        return rel.includes('noopenner') ? relStr : `rel="${rel} noopener"`;
+        return rel.includes('noopener') ? relStr : `rel="${rel} noopener"`;
       });
       return str.replace('href=', 'target="_blank" href=');
     }
diff --git a/lib/plugins/filter/after_render/external_link.ts b/lib/plugins/filter/after_render/external_link.ts
@@ -8,7 +8,7 @@ const rRelAttr = /rel=/i;
 const rRelStrAttr = /rel=["']([^<>"']*)["']/i;
 
 const addNoopener = (relStr: string, rel: string) => {
-  return rel.includes('noopenner') ? relStr : `rel="${rel} noopener"`;
+  return rel.includes('noopener') ? relStr : `rel="${rel} noopener"`;
 };
 
 function externalLinkFilter(this: Hexo, data: string): string {
diff --git a/test/scripts/filters/external_link.ts b/test/scripts/filters/external_link.ts
@@ -56,10 +56,10 @@ describe('External link', () => {
       '2. External link with "rel" Attribute',
       '<a rel="external" href="https://hexo.io/">Hexo</a>',
       '<a href="https://hexo.io/" rel="external">Hexo</a>',
-      '<a rel="noopenner" href="https://hexo.io/">Hexo</a>',
-      '<a href="https://hexo.io/" rel="noopenner">Hexo</a>',
-      '<a rel="external noopenner" href="https://hexo.io/">Hexo</a>',
-      '<a href="https://hexo.io/" rel="external noopenner">Hexo</a>',
+      '<a rel="noopener" href="https://hexo.io/">Hexo</a>',
+      '<a href="https://hexo.io/" rel="noopener">Hexo</a>',
+      '<a rel="external noopener" href="https://hexo.io/">Hexo</a>',
+      '<a href="https://hexo.io/" rel="external noopener">Hexo</a>',
       '3. External link with Other Attributes',
       '<a class="img" href="https://hexo.io/">Hexo</a>',
       '<a href="https://hexo.io/" class="img">Hexo</a>',
@@ -82,10 +82,10 @@ describe('External link', () => {
       '2. External link with "rel" Attribute',
       '<a rel="external noopener" target="_blank" href="https://hexo.io/">Hexo</a>',
       '<a target="_blank" href="https://hexo.io/" rel="external noopener">Hexo</a>',
-      '<a rel="noopenner" target="_blank" href="https://hexo.io/">Hexo</a>',
-      '<a target="_blank" href="https://hexo.io/" rel="noopenner">Hexo</a>',
-      '<a rel="external noopenner" target="_blank" href="https://hexo.io/">Hexo</a>',
-      '<a target="_blank" href="https://hexo.io/" rel="external noopenner">Hexo</a>',
+      '<a rel="noopener" target="_blank" href="https://hexo.io/">Hexo</a>',
+      '<a target="_blank" href="https://hexo.io/" rel="noopener">Hexo</a>',
+      '<a rel="external noopener" target="_blank" href="https://hexo.io/">Hexo</a>',
+      '<a target="_blank" href="https://hexo.io/" rel="external noopener">Hexo</a>',
       '3. External link with Other Attributes',
       '<a class="img" target="_blank" rel="noopener" href="https://hexo.io/">Hexo</a>',
       '<a target="_blank" rel="noopener" href="https://hexo.io/" class="img">Hexo</a>',
@@ -198,10 +198,10 @@ describe('External link - post', () => {
       '3. External link with "rel" Attribute',
       '<a rel="external" href="https://hexo.io/">Hexo</a>',
       '<a href="https://hexo.io/" rel="external">Hexo</a>',
-      '<a rel="noopenner" href="https://hexo.io/">Hexo</a>',
-      '<a href="https://hexo.io/" rel="noopenner">Hexo</a>',
-      '<a rel="external noopenner" href="https://hexo.io/">Hexo</a>',
-      '<a href="https://hexo.io/" rel="external noopenner">Hexo</a>',
+      '<a rel="noopener" href="https://hexo.io/">Hexo</a>',
+      '<a href="https://hexo.io/" rel="noopener">Hexo</a>',
+      '<a rel="external noopener" href="https://hexo.io/">Hexo</a>',
+      '<a href="https://hexo.io/" rel="external noopener">Hexo</a>',
       '4. External link with Other Attributes',
       '<a class="img" href="https://hexo.io/">Hexo</a>',
       '<a href="https://hexo.io/" class="img">Hexo</a>',
@@ -229,10 +229,10 @@ describe('External link - post', () => {
       '3. External link with "rel" Attribute',
       '<a rel="external noopener" target="_blank" href="https://hexo.io/">Hexo</a>',
       '<a target="_blank" href="https://hexo.io/" rel="external noopener">Hexo</a>',
-      '<a rel="noopenner" target="_blank" href="https://hexo.io/">Hexo</a>',
-      '<a target="_blank" href="https://hexo.io/" rel="noopenner">Hexo</a>',
-      '<a rel="external noopenner" target="_blank" href="https://hexo.io/">Hexo</a>',
-      '<a target="_blank" href="https://hexo.io/" rel="external noopenner">Hexo</a>',
+      '<a rel="noopener" target="_blank" href="https://hexo.io/">Hexo</a>',
+      '<a target="_blank" href="https://hexo.io/" rel="noopener">Hexo</a>',
+      '<a rel="external noopener" target="_blank" href="https://hexo.io/">Hexo</a>',
+      '<a target="_blank" href="https://hexo.io/" rel="external noopener">Hexo</a>',
       '4. External link with Other Attributes',
       '<a class="img" target="_blank" rel="noopener" href="https://hexo.io/">Hexo</a>',
       '<a target="_blank" rel="noopener" href="https://hexo.io/" class="img">Hexo</a>',

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ function externalLinkFilter(this: Hexo, data: RenderData): void {`
`23`	`23`
`24`	`24`	`if (rRelAttr.test(str)) {`
`25`	`25`	`str = str.replace(rRelStrAttr, (relStr, rel) => {`
`26`		- return rel.includes('noopenner') ? relStr : `rel="${rel} noopener"`;
	`26`	+ return rel.includes('noopener') ? relStr : `rel="${rel} noopener"`;
`27`	`27`	`});`
`28`	`28`	`return str.replace('href=', 'target="_blank" href=');`
`29`	`29`	`}`