test: run issue 245 forensic repro

Author: dsarno

.github/workflows/forensic-issue-245.yml

@@ -0,0 +1,60 @@
+name: Forensic / issue-245 dictionary hot-reload
+
+# Manual one-shot to verify the "newly-introduced typed Dictionary field
+# stays NIL after hot-reload" bug across Linux, macOS, and Windows Godot
+# 4.6.2-stable runners. Initial macOS run from a Mac confirmed the crash;
+# this workflow checks Linux + Windows + a second macOS for completeness.
+
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - tmp/forensic-issue-245-run
+    paths:
+      - .github/workflows/forensic-issue-245.yml
+      - docs/forensic/issue-245/**
+
+jobs:
+  synthetic:
+    name: Synthetic / ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
+
+    steps:
+      - uses: actions/checkout@v6
+
+      - uses: chickensoft-games/setup-godot@v2
+        with:
+          version: 4.6.2
+          use-dotnet: false
+
+      - name: Run synthetic dictionary-injection test
+        shell: bash
+        run: |
+          set +e
+          godot --headless --editor \
+            --path docs/forensic/issue-245/repro-dictinject \
+            --quit-after 1500 > synthetic.log 2>&1
+          rc=$?
+          echo "::group::Full Godot output"
+          cat synthetic.log
+          echo "::endgroup::"
+          echo "exit code: $rc"
+          echo
+          echo "===== Verdict ====="
+          if grep -q "post-reload property names" synthetic.log; then
+            grep "post-reload property names" synthetic.log
+          fi
+          if grep -q "inst.get('injected_dict')" synthetic.log; then
+            grep "inst.get('injected_dict')" synthetic.log
+          fi
+          if grep -q "Program crashed with signal" synthetic.log; then
+            echo "RESULT: CRASH (Dictionary::keys on null _p)"
+          elif grep -q "DONE — no SIGABRT" synthetic.log; then
+            echo "RESULT: OK (no crash, hot-reload initialized field correctly)"
+          else
+            echo "RESULT: INDETERMINATE (test did not complete normally; rc=$rc)"
+          fi

docs/forensic/issue-245/repro-dictinject/addons/repro/plugin.cfg

@@ -0,0 +1,7 @@
+[plugin]
+
+name="Repro DictInject"
+description="Synthetic test for Dictionary hot-reload field injection bug (#245)"
+author="dsarno"
+version="0.1"
+script="plugin.gd"

docs/forensic/issue-245/repro-dictinject/addons/repro/plugin.gd

@@ -0,0 +1,121 @@
+@tool
+extends EditorPlugin
+
+# Synthetic test for #245: macOS Godot 4.6.2-mono leaves a newly-injected
+# Dictionary field with null _p after hot-reloading the script class on a
+# live instance. Models the v2.1.1 → v2.1.2 self-update path of godot-ai.
+#
+# Sequence on _enter_tree (deferred so editor is fully booted):
+#   1) stage repro_v1.gd content into res://repro.gd
+#   2) construct an instance of v1
+#   3) overwrite res://repro.gd with v2 content (adds Dictionary field)
+#   4) trigger filesystem rescan + script reload
+#   5) read instance.injected_dict.keys() — bug fires here
+
+var _instance: RefCounted
+
+
+func _enter_tree() -> void:
+	print("[repro] _enter_tree — scheduling test")
+	get_tree().create_timer(2.0).timeout.connect(_step_1_stage_v1)
+
+
+func _exit_tree() -> void:
+	pass
+
+
+func _read_text(p: String) -> String:
+	var f := FileAccess.open(p, FileAccess.READ)
+	if f == null:
+		print("[repro] FAIL: cannot read %s" % p)
+		return ""
+	var s := f.get_as_text()
+	f.close()
+	return s
+
+
+func _write_text(p: String, content: String) -> void:
+	var f := FileAccess.open(p, FileAccess.WRITE)
+	if f == null:
+		print("[repro] FAIL: cannot open %s for write" % p)
+		return
+	f.store_string(content)
+	f.close()
+
+
+func _step_1_stage_v1() -> void:
+	print("[repro] step 1: stage v1 at res://repro.gd")
+	var v1: String = _read_text("res://repro_v1.gd")
+	_write_text("res://repro.gd", v1)
+	EditorInterface.get_resource_filesystem().scan()
+	get_tree().create_timer(2.0).timeout.connect(_step_2_construct_v1)
+
+
+func _step_2_construct_v1() -> void:
+	print("[repro] step 2: construct v1 instance")
+	var script_v1: GDScript = load("res://repro.gd") as GDScript
+	if script_v1 == null:
+		print("[repro] FAIL: v1 class did not load")
+		return
+	_instance = script_v1.new()
+	if _instance == null:
+		print("[repro] FAIL: v1 instance is null")
+		return
+	print("[repro] v1 instance: %s" % _instance)
+	var s: Variant = _instance.call("say")
+	print("[repro] v1 .say() -> %s" % str(s))
+	var prop_names: Array[String] = []
+	for p in _instance.get_property_list():
+		prop_names.append(p["name"])
+	print("[repro] v1 property names: %s" % str(prop_names))
+	get_tree().create_timer(1.0).timeout.connect(_step_3_overwrite_to_v2)
+
+
+func _step_3_overwrite_to_v2() -> void:
+	print("[repro] step 3: overwrite res://repro.gd with v2 (adds Dictionary field)")
+	var v2: String = _read_text("res://repro_v2.gd")
+	_write_text("res://repro.gd", v2)
+	EditorInterface.get_resource_filesystem().scan()
+	get_tree().create_timer(3.0).timeout.connect(_step_4_force_reload)
+
+
+func _step_4_force_reload() -> void:
+	print("[repro] step 4: force script reload + reimport")
+	EditorInterface.get_resource_filesystem().reimport_files(PackedStringArray(["res://repro.gd"]))
+	get_tree().create_timer(2.0).timeout.connect(_step_5_probe)
+
+
+func _step_5_probe() -> void:
+	print("[repro] step 5: probe instance after hot-reload")
+	if _instance == null:
+		print("[repro] FAIL: instance was GC'd")
+		_quit_with(1)
+		return
+	var prop_names: Array[String] = []
+	for p in _instance.get_property_list():
+		prop_names.append(p["name"])
+	print("[repro] post-reload property names: %s" % str(prop_names))
+
+	var v: Variant = _instance.get("injected_dict")
+	print("[repro] inst.get('injected_dict'): typeof=%d value=%s" % [typeof(v), str(v)])
+
+	if typeof(v) == TYPE_DICTIONARY:
+		var d: Dictionary = v
+		print("[repro] is Dictionary; calling .keys()...")
+		# THIS is where the bug would crash (Dictionary::keys on null _p)
+		var k: Array = d.keys()
+		print("[repro] .keys() returned %s (size=%d)" % [str(k), k.size()])
+	else:
+		print("[repro] field is not Dictionary; type=%d" % typeof(v))
+
+	# Call the v2 .say() method which itself does injected_dict.keys()
+	print("[repro] calling inst.say() (v2 body)...")
+	var msg: Variant = _instance.call("say")
+	print("[repro] inst.say() -> %s" % str(msg))
+
+	print("[repro] DONE — no SIGABRT. Bug did NOT reproduce in synthetic.")
+	_quit_with(0)
+
+
+func _quit_with(code: int) -> void:
+	get_tree().create_timer(0.5).timeout.connect(func(): get_tree().quit(code))

docs/forensic/issue-245/repro-dictinject/addons/repro/plugin.gd.uid

@@ -0,0 +1 @@
+uid://fkcshrjxd5cs

docs/forensic/issue-245/repro-dictinject/main.tscn

@@ -0,0 +1,3 @@
+[gd_scene format=3 uid="uid://b00000000000y"]
+
+[node name="Main" type="Node"]

docs/forensic/issue-245/repro-dictinject/project.godot

@@ -0,0 +1,13 @@
+; Engine configuration file for synthetic Dictionary-injection hot-reload test.
+
+config_version=5
+
+[application]
+
+config/name="repro-dictinject"
+config/features=PackedStringArray("4.6")
+run/main_scene="res://main.tscn"
+
+[editor_plugins]
+
+enabled=PackedStringArray("res://addons/repro/plugin.cfg")

docs/forensic/issue-245/repro-dictinject/repro_v1.gd

@@ -0,0 +1,5 @@
+class_name Repro
+extends RefCounted
+
+func say() -> String:
+	return "v1: no injected_dict field"

docs/forensic/issue-245/repro-dictinject/repro_v1.gd.uid

@@ -0,0 +1 @@
+uid://dylc8rkmwoca3

docs/forensic/issue-245/repro-dictinject/repro_v2.gd

@@ -0,0 +1,7 @@
+class_name Repro
+extends RefCounted
+
+var injected_dict: Dictionary = {}
+
+func say() -> String:
+	return "v2: injected_dict.keys() = %s" % str(injected_dict.keys())

docs/forensic/issue-245/repro-dictinject/repro_v2.gd.uid

@@ -0,0 +1 @@
+uid://b2iks11w20k8c