Address API introspection review feedback

Author: Joshua

docs/TOOLS.md

@@ -90,7 +90,8 @@ without creating an instance. By default it returns direct class members only,
 with each returned section capped at 100 items. Pass `sections` (`properties`,
 `methods`, `signals`, `enums`, `constants`, `inheritors`),
 `include_inherited=true`, `include_inheritors=true`, `offset`, or `limit=0`
-when a fuller class reference is needed.
+when a fuller class reference is needed. When paginating, request one section
+at a time so `offset`/`limit` apply only to the list you are paging.
 
 Every rolled-up tool also accepts an optional top-level `session_id` for
 per-call multi-editor routing (sibling of `op` and `params`, *not* nested

plugin/addons/godot_ai/handlers/api_handler.gd

@@ -19,6 +19,11 @@ func get_class_info(params: Dictionary) -> Dictionary:
 		if not script_class.is_empty():
 			return _script_class_error(requested_class, script_class)
 		return _unknown_class_error(requested_class)
+	if params.has("limit") and int(params.get("limit")) < 0:
+		return ErrorCodes.make(
+			ErrorCodes.INVALID_PARAMS,
+			"limit must be >= 0; use limit=0 only when an unlimited section is needed"
+		)
 	var section_check := ClassIntrospection.validate_sections(
 		params.get("sections", ClassIntrospection.DEFAULT_SECTIONS)
 	)

plugin/addons/godot_ai/utils/class_introspection.gd

@@ -17,7 +17,7 @@ static func build(type_name: String, options: Dictionary = {}) -> Dictionary:
 	var offset := max(0, int(options.get("offset", 0)))
 	var limit := int(options.get("limit", MAX_DEFAULT_ITEMS))
 	if limit < 0:
-		limit = 0
+		limit = MAX_DEFAULT_ITEMS
 	var can_instantiate := ClassDB.can_instantiate(type_name)
 
 	var data := {
@@ -26,7 +26,7 @@ static func build(type_name: String, options: Dictionary = {}) -> Dictionary:
 		"parent_class": str(ClassDB.get_parent_class(type_name)),
 		"inheritance_chain": _inheritance_chain(type_name),
 		"can_instantiate": can_instantiate,
-		"is_abstract": not can_instantiate,
+		"is_singleton": Engine.has_singleton(type_name),
 		"include_inherited": include_inherited,
 		"offset": offset,
 		"limit": limit,

plugin/addons/godot_ai/utils/variant_serializer.gd

@@ -53,7 +53,7 @@ static func serialize(value: Variant) -> Variant:
 			}
 		TYPE_NODE_PATH:
 			return str(value)
-		TYPE_ARRAY, TYPE_PACKED_BYTE_ARRAY, TYPE_PACKED_INT32_ARRAY, TYPE_PACKED_INT64_ARRAY, TYPE_PACKED_FLOAT32_ARRAY, TYPE_PACKED_FLOAT64_ARRAY, TYPE_PACKED_STRING_ARRAY, TYPE_PACKED_VECTOR2_ARRAY, TYPE_PACKED_VECTOR3_ARRAY, TYPE_PACKED_COLOR_ARRAY:
+		TYPE_ARRAY, TYPE_PACKED_BYTE_ARRAY, TYPE_PACKED_INT32_ARRAY, TYPE_PACKED_INT64_ARRAY, TYPE_PACKED_FLOAT32_ARRAY, TYPE_PACKED_FLOAT64_ARRAY, TYPE_PACKED_STRING_ARRAY, TYPE_PACKED_VECTOR2_ARRAY, TYPE_PACKED_VECTOR3_ARRAY, TYPE_PACKED_VECTOR4_ARRAY, TYPE_PACKED_COLOR_ARRAY:
 			var arr: Array = []
 			for item in value:
 				arr.append(serialize(item))

src/godot_ai/handlers/editor.py

@@ -321,10 +321,6 @@ async def editor_reload_plugin(runtime: DirectRuntime) -> dict:
 
 
 async def _dispatch_reload_async(runtime: DirectRuntime, old_id: str) -> None:
-    ## Start the grace delay on the next event-loop turn. That gives the
-    ## caller's response path a chance to continue before this background task
-    ## begins counting down toward the WebSocket reload command.
-    await asyncio.sleep(0)
     if PLUGIN_MANAGED_RELOAD_DELAY_SEC > 0:
         await asyncio.sleep(PLUGIN_MANAGED_RELOAD_DELAY_SEC)
     try:

src/godot_ai/tools/api.py

@@ -21,6 +21,8 @@
         Return selected class-reference sections without creating a scene
         instance. sections may be a comma-separated string or list containing
         properties, methods, signals, enums, constants, inheritors.
+        For pagination, request one section at a time so offset/limit apply
+        only to the list you are paging.
 """
 
 

test_project/tests/test_api.gd

@@ -46,6 +46,27 @@ func test_get_class_info_invalid_section_suggests_plural() -> void:
 	assert_contains(result.error.data.suggestions.method, "methods")
 
 
+func test_get_class_info_negative_limit_errors() -> void:
+	var result := _handler.get_class_info({
+		"class_name": "CharacterBody3D",
+		"limit": -1,
+	})
+	assert_is_error(result, ErrorCodes.INVALID_PARAMS)
+	assert_contains(result.error.message, "limit")
+
+
+func test_get_class_info_singleton_does_not_report_abstract() -> void:
+	var result := _handler.get_class_info({
+		"class_name": "Input",
+		"sections": ["methods"],
+		"limit": 1,
+	})
+	assert_has_key(result, "data")
+	assert_false(result.data.has("is_abstract"))
+	assert_false(result.data.can_instantiate)
+	assert_true(result.data.is_singleton)
+
+
 func test_get_class_info_character_body_3d() -> void:
 	var result := _handler.get_class_info({
 		"class_name": "CharacterBody3D",
@@ -54,6 +75,7 @@ func test_get_class_info_character_body_3d() -> void:
 	})
 	assert_has_key(result, "data")
 	assert_eq(result.data.class_name, "CharacterBody3D")
+	assert_false(result.data.has("is_abstract"))
 	assert_contains(result.data.inheritance_chain, "PhysicsBody3D")
 	assert_contains(result.data.inheritance_chain, "Node")
 	assert_gt(result.data.property_count, 0)

test_project/tests/test_node.gd

@@ -1146,6 +1146,13 @@ func test_serialize_packed_vector3_array_returns_xyz_dicts() -> void:
 	assert_eq(result[0]["z"], 3.0)
 
 
+func test_serialize_packed_vector4_array_returns_xyzw_dicts() -> void:
+	var result = NodeHandler._serialize_value(PackedVector4Array([Vector4(1, 2, 3, 4)]))
+	assert_true(result is Array)
+	assert_eq(result[0]["x"], 1.0)
+	assert_eq(result[0]["w"], 4.0)
+
+
 func test_serialize_packed_color_array_returns_rgba_dicts() -> void:
 	var result = NodeHandler._serialize_value(PackedColorArray([Color(1, 0, 0, 0.5)]))
 	assert_true(result is Array)

test_project/tests/test_resource.gd

@@ -347,9 +347,16 @@ func test_get_resource_info_concrete_type_box_mesh() -> void:
 	assert_false(result.data.is_abstract)
 	assert_gt(result.data.property_count, 0)
 	var prop_names: Array = []
+	var size_prop: Dictionary = {}
 	for p in result.data.properties:
 		prop_names.append(p.name)
+		if p.name == "size":
+			size_prop = p
 	assert_contains(prop_names, "size", "BoxMesh.size must appear in properties")
+	assert_has_key(size_prop, "default")
+	assert_eq(size_prop.default.x, 1.0)
+	assert_eq(size_prop.default.y, 1.0)
+	assert_eq(size_prop.default.z, 1.0)
 
 
 func test_get_resource_info_concrete_type_cylinder_mesh() -> void: