Tighten 7 tests that passed without verifying behavior (#458)

* Tighten 7 tests that passed without verifying behavior

Audit of the GDScript + Python test suites surfaced seven tests whose
assertions didn't actually pin down the behavior they claimed to test —
they would have stayed green under regressions in the code paths they
exercise.

GDScript (test_project/tests/):
- test_theme.gd::test_theme_set_color_accepts_dict only checked the
  response envelope. Now reloads the theme and asserts the stored value
  is a Color with the right channels, so a missing dict->Color coercion
  can't pass.
- test_theme.gd::test_create_theme_overwrite_allowed and
  test_material.gd::test_create_overwrite_allowed now assert
  overwritten=true on the response and that the target file still
  exists, instead of just confirming the call returned data.
- test_material.gd::test_set_param_bool now reads emission_enabled back
  off the loaded material (matching the read-back pattern its float and
  color siblings already use).
- test_animation.gd::test_add_property_track_transition_raw_float now
  reads the stored keyframes and asserts both that the dict values
  coerced to Vector3 and that the raw-float transition landed on each
  key — the prior version would pass even if either silently no-oped.

Python (tests/unit/):
- test_runtime_handlers.py::test_audio_player_create_blocks_when_not_writable
  was catching bare Exception, which would mask unrelated bugs. Narrowed
  to GodotCommandError to match the surrounding readiness-gate tests.
- test_self_update_smoke_harness.py::test_v240_preflight_passes_when_both_files_present
  had zero assertions — it called the validator and returned. Added an
  assertion that the call returns None so the runner's zero-assertion
  guard has something to verify and the intent is documented.

https://claude.ai/code/session_01H8CLhwuNUA4NoEZ4neJk78

* Retrigger CI for Windows Godot tests

Linux + macOS Godot tests passed on the previous run; Windows failed in
~89s (vs ~134s on green main-branch runs), suggesting either a flake or
an early-pipeline failure. Pushing this empty commit to disambiguate.

https://claude.ai/code/session_01H8CLhwuNUA4NoEZ4neJk78

* Address review follow-ups on PR #458

- test_animation.gd: add value assert for v0 so both keyframes carry the
  same depth of check (was: only v1 had a value assert; v0 was type-only).
- test_theme.gd: assert the alpha channel in
  test_theme_set_color_accepts_dict — the test dict explicitly passes
  a=1.0, so leaving it unchecked left a gap in the dict→Color coercion
  coverage.

https://claude.ai/code/session_01H8CLhwuNUA4NoEZ4neJk78

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: dsarno

test_project/tests/test_animation.gd

@@ -569,6 +569,21 @@ func test_add_property_track_transition_raw_float() -> void:
 		],
 	})
 	assert_has_key(result, "data")
+	# Read back the stored keyframes so a broken dict→Vector3 coercion or a
+	# silently-dropped transition can't pass this test.
+	var scene_root := EditorInterface.get_edited_scene_root()
+	var player := McpScenePath.resolve(player_path, scene_root) as AnimationPlayer
+	var anim: Animation = player.get_animation("anim")
+	var v0 = anim.track_get_key_value(0, 0)
+	var v1 = anim.track_get_key_value(0, 1)
+	assert_true(v0 is Vector3, "from value must coerce to Vector3, not stay as Dict")
+	assert_true(v1 is Vector3, "to value must coerce to Vector3, not stay as Dict")
+	assert_eq(v0.x, 0.0)
+	assert_eq(v1.x, 100.0)
+	assert_true(abs(anim.track_get_key_transition(0, 0) - 3.0) < 0.0001,
+		"raw-float transition should be stored on key 0")
+	assert_true(abs(anim.track_get_key_transition(0, 1) - 3.0) < 0.0001,
+		"raw-float transition should be stored on key 1")
 	_remove_node(player_path)
 
 

test_project/tests/test_material.gd

@@ -119,6 +119,10 @@ func test_create_overwrite_allowed() -> void:
 	_make_material()
 	var result := _handler.create_material({"path": TEST_MATERIAL_PATH, "overwrite": true})
 	assert_has_key(result, "data")
+	assert_eq(result.data.overwritten, true,
+		"overwritten flag must reflect the pre-existing file")
+	assert_true(FileAccess.file_exists(TEST_MATERIAL_PATH),
+		"material file should still exist after overwrite")
 
 
 func test_create_shader_requires_shader_path() -> void:
@@ -179,6 +183,9 @@ func test_set_param_bool() -> void:
 		"value": true,
 	})
 	assert_has_key(result, "data")
+	var mat: Material = ResourceLoader.load(TEST_MATERIAL_PATH)
+	assert_eq(mat.get("emission_enabled"), true,
+		"emission_enabled should be stored as the bool we passed")
 
 
 func test_set_param_transparency_enum_by_name() -> void:

test_project/tests/test_theme.gd

@@ -65,6 +65,10 @@ func test_create_theme_overwrite_allowed() -> void:
 	_make_theme()
 	var result := _handler.create_theme({"path": TEST_THEME_PATH, "overwrite": true})
 	assert_has_key(result, "data")
+	assert_eq(result.data.overwritten, true,
+		"overwritten flag must reflect the pre-existing file")
+	assert_true(FileAccess.file_exists(TEST_THEME_PATH),
+		"theme file should still exist after overwrite")
 
 
 # ----- theme_set_color -----
@@ -96,6 +100,16 @@ func test_theme_set_color_accepts_dict() -> void:
 		"value": {"r": 0.5, "g": 0.3, "b": 0.1, "a": 1.0},
 	})
 	assert_has_key(result, "data")
+	# Read back from disk so a missing dict→Color coercion can't pass by
+	# returning a successful envelope while storing a raw Dict.
+	var theme: Theme = ResourceLoader.load(TEST_THEME_PATH)
+	assert_true(theme.has_color("font_color", "Label"))
+	var c := theme.get_color("font_color", "Label")
+	assert_true(c is Color, "Stored value must be a Color, not a raw Dict")
+	assert_true(abs(c.r - 0.5) < 0.01)
+	assert_true(abs(c.g - 0.3) < 0.01)
+	assert_true(abs(c.b - 0.1) < 0.01)
+	assert_true(abs(c.a - 1.0) < 0.01)
 
 
 func test_theme_set_color_rejects_garbage_string() -> void:

tests/unit/test_runtime_handlers.py

@@ -4869,6 +4869,8 @@ async def test_audio_list_handler_is_read_only():
 
 async def test_audio_player_create_blocks_when_not_writable():
     """audio_player_create requires a writable session (uses require_writable)."""
+    from godot_ai.godot_client.client import GodotCommandError
+
     client = StubClient()
     client.live_readiness = "playing"
     session = Session(
@@ -4881,7 +4883,7 @@ async def test_audio_player_create_blocks_when_not_writable():
     registry = SessionRegistry()
     registry.register(session)
     runtime = DirectRuntime(registry=registry, client=client)
-    with pytest.raises(Exception) as exc_info:
+    with pytest.raises(GodotCommandError) as exc_info:
         await audio_handlers.audio_player_create(runtime, parent_path="/Main")
     assert "play mode" in str(exc_info.value).lower()
     ## The gate fires one `get_editor_state` probe to confirm the cache

tests/unit/test_self_update_smoke_harness.py

@@ -229,7 +229,9 @@ def test_v240_preflight_passes_when_both_files_present(tmp_path: Path) -> None:
         tmp_path,
         present=("utils/server_lifecycle.gd", "utils/update_manager.gd"),
     )
-    smoke._require_v240_plus_addon_shape(addon, "2.4.0")
+    # Validator returns None on success and raises HarnessError otherwise; the
+    # assertion both documents intent and trips the runner's zero-assertion guard.
+    assert smoke._require_v240_plus_addon_shape(addon, "2.4.0") is None
 
 
 @pytest.mark.parametrize(