feat(1719): mirror node callcontract response validation (#1753)

Signed-off-by: rozekmichal <michal.rozek@blockydevs.com>

Author: rozekmichal

src/core/services/contract-verifier/contract-verifier-service.ts

@@ -3,13 +3,16 @@ import type { ContractVerifierService } from '@/core/services/contract-verifier/
 import type {
   ContractVerificationParams,
   ContractVerificationResult,
-  SmartContractVerifyApiErrorResponse,
-  SmartContractVerifyApiOkResponse,
 } from '@/core/services/contract-verifier/types';
 
 import fs from 'fs/promises';
 import path from 'path';
 
+import {
+  SmartContractVerifyApiErrorResponseSchema,
+  SmartContractVerifyApiOkResponseSchema,
+} from '@/core/services/contract-verifier/schema';
+import { parseWithSchema } from '@/core/shared/validation/parse-with-schema.zod';
 import { NetworkChainMap } from '@/core/types/shared.types';
 import { scanSolidityFiles } from '@/core/utils/solidity-file-importer';
 
@@ -57,10 +60,12 @@ export class ContractVerifierServiceImpl implements ContractVerifierService {
       if (!response.ok) {
         let errorMessage: string;
         try {
-          const errorData =
-            (await response.json()) as SmartContractVerifyApiErrorResponse;
-          errorMessage =
-            errorData.error ?? `${response.status} ${response.statusText}`;
+          const parsed = SmartContractVerifyApiErrorResponseSchema.safeParse(
+            await response.json(),
+          );
+          errorMessage = parsed.success
+            ? (parsed.data.error ?? `${response.status} ${response.statusText}`)
+            : `${response.status} ${response.statusText}`;
         } catch {
           errorMessage = `${response.status} ${response.statusText}`;
         }
@@ -71,7 +76,11 @@ export class ContractVerifierServiceImpl implements ContractVerifierService {
         };
       }
 
-      const data = (await response.json()) as SmartContractVerifyApiOkResponse;
+      const data = parseWithSchema(
+        SmartContractVerifyApiOkResponseSchema,
+        await response.json(),
+        'Hashscan verify API POST /verify',
+      );
 
       return {
         success: true,

src/core/services/contract-verifier/schema.ts

@@ -0,0 +1,24 @@
+import type {
+  SmartContractVerifyApiErrorResponse,
+  SmartContractVerifyApiOkResponse,
+} from './types';
+
+import { z } from 'zod';
+
+const verifyResultItemSchema = z.object({
+  address: z.string(),
+  chainId: z.string(),
+  status: z.string(),
+  message: z.string(),
+  libraryMap: z.record(z.string(), z.unknown()),
+});
+
+export const SmartContractVerifyApiOkResponseSchema: z.ZodType<SmartContractVerifyApiOkResponse> =
+  z.object({
+    result: z.array(verifyResultItemSchema).min(1),
+  });
+
+export const SmartContractVerifyApiErrorResponseSchema: z.ZodType<SmartContractVerifyApiErrorResponse> =
+  z.object({
+    error: z.string(),
+  });

src/core/services/mirrornode/hedera-mirrornode-service.ts

@@ -36,6 +36,7 @@ import { handleMirrorNodeErrorResponse } from '@/core/utils/handle-mirror-node-e
 
 import {
   AccountAPIResponseSchema,
+  ContractCallResponseSchema,
   ContractInfoSchema,
   ExchangeRateResponseSchema,
   GetAccountsAPIResponseSchema,
@@ -602,7 +603,11 @@ export class HederaMirrornodeServiceDefaultImpl implements HederaMirrornodeServi
         );
       }
 
-      return (await response.json()) as ContractCallResponse;
+      return parseWithSchema(
+        ContractCallResponseSchema,
+        await response.json(),
+        'Mirror Node POST /contracts/call',
+      );
     } catch (error) {
       if (error instanceof CliError) throw error;
       throw new NetworkError('Failed to call contract via mirror node', {

src/core/services/mirrornode/schemas.ts

@@ -7,6 +7,7 @@ import {
   type AccountListItemAPIResponse,
   type AccountListItemBalance,
   type AccountListItemTokenBalance,
+  type ContractCallResponse,
   type ContractInfo,
   type ExchangeRateResponse,
   type GetAccountsAPIResponse,
@@ -232,6 +233,11 @@ export const ContractInfoSchema: z.ZodType<ContractInfo> = z.object({
   stake_period_start: nullableStringKey,
 });
 
+export const ContractCallResponseSchema: z.ZodType<ContractCallResponse> =
+  z.object({
+    result: z.string(),
+  });
+
 const exchangeRateBandSchema = z.object({
   cent_equivalent: z.number(),
   expiration_time: z.number(),