Changes for new version of xgboost#30
Merged
holub008 merged 9 commits intoholub008:masterfrom Dec 4, 2025
Merged
Conversation
holub008
reviewed
Nov 23, 2025
Contributor
Author
|
I think XGBoost has sent their new version to CRAN. Would you like me to do anything different for either of these comments? |
Owner
|
Thank you for the explanations, we are good! I got the failing build alert from CRAN this afternoon, so let's get it out the door. If you add in the xgb version requirement > 3.1.2.1 and cleanup the dev xgb install, I'll merge this in, do some final testing, and publish to CRAN. I'm so appreciative of your work @topepo ! |
Contributor
Author
|
I made those updates. Good luck 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
See dmlc/xgboost#11430
There is no version requirement for xgboost in the description file. Once the new version of xgboost is on CRAN, we can revert c2f87f9 and send xrf to CRAN.
Main changes here:
xgb.train()instead ofxgboost().summary.xrf().