Skip to content

Commit 83452e9

Browse files
committed
open accessory info on tile loading icon click
1 parent 9c0de3e commit 83452e9

32 files changed

Lines changed: 76 additions & 43 deletions

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ All notable changes to `homebridge-config-ui-x` will be documented in this file.
1111
- feat: add separate beta preferences for plugins (#2687) (@seidnerj)
1212
- further tweaks for node + plugin update preferences
1313
- fix manage plugin show back btn after plugin install
14+
- open accessory info on tile loading icon click
1415

1516
### Homebridge Dependencies
1617

ui/src/app/core/accessories/accessory-info/accessory-info.component.html

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,10 @@ <h6 class="mb-0 text-center">{{ 'accessories.service_info' | translate }}</h6>
206206
<li class="list-group-item">
207207
<h6 class="mb-0 text-center">{{ 'accessories.accessory_info' | translate }}</h6>
208208
</li>
209+
<li class="list-group-item d-flex justify-content-between align-items-left flex-column flex-md-row">
210+
<span class="text-start">{{ 'accessories.protocol' | translate }}</span>
211+
<span class="text-start text-md-end grey-text font-monospace">HAP</span>
212+
</li>
209213
@if (matchedCachedAccessory) {
210214
<li class="list-group-item d-flex justify-content-between align-items-left flex-column flex-md-row">
211215
<span class="text-start">{{ 'accessories.plugin' | translate }}</span>
@@ -246,9 +250,7 @@ <h6 class="mb-0 text-center">{{ 'accessories.accessory_info' | translate }}</h6>
246250
<span class="text-start text-md-end grey-text font-monospace">{{ service.instance.port }}</span>
247251
</li>
248252
<li class="list-group-item d-flex justify-content-between align-items-left flex-column flex-md-row">
249-
<span class="text-start align-self-md-center" style="white-space: nowrap"
250-
>{{ 'accessories.unique_id' | translate }}</span
251-
>
253+
<span class="text-start align-self-md-center" style="white-space: nowrap">HAP UID</span>
252254
<span
253255
class="text-start text-md-end grey-text font-monospace d-flex justify-content-between align-items-center ms-md-2"
254256
>

ui/src/app/core/accessories/accessory-tile/accessory-tile.component.html

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,14 @@
99
<i class="fas fa-bars grey-text" aria-hidden="true"></i>
1010
</button>
1111
} @if (!$accessories.readyForControl) {
12-
<i class="fas fa-circle-notch fa-spin refreshing-accessory-status-icon grey-text"></i>
12+
<button
13+
type="button"
14+
class="refreshing-accessory-button"
15+
(click)="$accessories.showAccessoryInformation(service)"
16+
[attr.aria-label]="('form.button_edit' | translate) + ' ' + (service.customName || service.serviceName)"
17+
>
18+
<i class="fas fa-circle-notch fa-spin grey-text" aria-hidden="true"></i>
19+
</button>
1320
} @switch (service.customType || service.type) { @case ('Switch') {
1421
<app-switch [service]="service" [readyForControl]="$accessories.readyForControl">
1522
{{ 'accessories.core.switch' | translate }}

ui/src/i18n/bg.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@
133133
"accessories.only_ui": "These settings are only for the Homebridge UI and <strong>will not be reflected in HomeKit</strong>.",
134134
"accessories.only_ui_2": "These options are unique to your Homebridge UI account.",
135135
"accessories.plugin": "Plugin",
136+
"accessories.protocol": "Protocol",
136137
"accessories.room_name": "Име на стая",
137138
"accessories.service": "Service",
138139
"accessories.service_info": "Service Information",
@@ -144,7 +145,6 @@
144145
"accessories.support.rooms_2": "To rename an existing room, create a new room with the desired name and move the accessories to the new room.",
145146
"accessories.support.rooms_3": "To delete an existing room, move all its accessories to another room and refresh the page.",
146147
"accessories.title_rooms": "Rooms",
147-
"accessories.unique_id": "Unique ID",
148148
"backup.backup_delete_failed": "Backup deletion failed. See logs for details.",
149149
"backup.backup_download_failed": "Backup download failed.",
150150
"backup.backup_exceeds_max_size": "Backup ({{ backupSize }}) exceeds maximum restore file size of {{ maxBackupSizeText }}",

ui/src/i18n/ca.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@
133133
"accessories.only_ui": "These settings are only for the Homebridge UI and <strong>will not be reflected in HomeKit</strong>.",
134134
"accessories.only_ui_2": "These options are unique to your Homebridge UI account.",
135135
"accessories.plugin": "Plugin",
136+
"accessories.protocol": "Protocol",
136137
"accessories.room_name": "Nom de l'habitació",
137138
"accessories.service": "Service",
138139
"accessories.service_info": "Service Information",
@@ -144,7 +145,6 @@
144145
"accessories.support.rooms_2": "To rename an existing room, create a new room with the desired name and move the accessories to the new room.",
145146
"accessories.support.rooms_3": "To delete an existing room, move all its accessories to another room and refresh the page.",
146147
"accessories.title_rooms": "Rooms",
147-
"accessories.unique_id": "Unique ID",
148148
"backup.backup_delete_failed": "Backup deletion failed. See logs for details.",
149149
"backup.backup_download_failed": "Error al descarregar l'arxiu de còpia de seguretat",
150150
"backup.backup_exceeds_max_size": "La còpia de seguretat ({{ backupSize }}) supera la mida màxima del fitxer de restauració de {{ maxBackupSizeText }}",

ui/src/i18n/cs.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@
133133
"accessories.only_ui": "These settings are only for the Homebridge UI and <strong>will not be reflected in HomeKit</strong>.",
134134
"accessories.only_ui_2": "These options are unique to your Homebridge UI account.",
135135
"accessories.plugin": "Plugin",
136+
"accessories.protocol": "Protocol",
136137
"accessories.room_name": "Jméno místnosti",
137138
"accessories.service": "Služba",
138139
"accessories.service_info": "Informace o službě",
@@ -144,7 +145,6 @@
144145
"accessories.support.rooms_2": "Chcete-li přejmenovat existující místnost, vytvořte novou místnost s požadovaným názvem a přesuňte příslušenství do nové místnosti.",
145146
"accessories.support.rooms_3": "Chcete-li smazat existující místnost, přesuňte všechna její příslušenství do jiné místnosti a obnovte stránku.",
146147
"accessories.title_rooms": "Rooms",
147-
"accessories.unique_id": "Unique ID",
148148
"backup.backup_delete_failed": "Odstranění zálohy se nezdařilo. Podrobnosti naleznete v protokolech.",
149149
"backup.backup_download_failed": "Stažení zálohy se nezdařilo",
150150
"backup.backup_exceeds_max_size": "Záloha ({{ backupSize }}) překračuje maximální velikost souboru pro obnovení {{ maxBackupSizeText }}",

ui/src/i18n/de.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@
133133
"accessories.only_ui": "Diese Einstellungen gelten nur für die Homebridge UI und <strong>wirken sich nicht auf HomeKit aus</strong>.",
134134
"accessories.only_ui_2": "Diese Optionen sind spezifisch für dein Homebridge UI-Benutzerkonto.",
135135
"accessories.plugin": "Plugin",
136+
"accessories.protocol": "Protocol",
136137
"accessories.room_name": "Raumname",
137138
"accessories.service": "Service",
138139
"accessories.service_info": "Service-Informationen",
@@ -144,7 +145,6 @@
144145
"accessories.support.rooms_2": "Um einen bestehenden Raum umzubenennen, erstelle einen neuen Raum mit dem gewünschten Namen und verschiebe die Geräte in den neuen Raum.",
145146
"accessories.support.rooms_3": "Um einen bestehenden Raum zu löschen, verschiebe alle Geräte in einen anderen Raum und aktualisiere die Seite.",
146147
"accessories.title_rooms": "Räume",
147-
"accessories.unique_id": "Unique ID",
148148
"backup.backup_delete_failed": "Löschen des Backups fehlgeschlagen. Siehe Logs für mehr Informationen.",
149149
"backup.backup_download_failed": "Backup-Download fehlgeschlagen",
150150
"backup.backup_exceeds_max_size": "Backup ({{ backupSize }}) überschreitet maximale Größe der Wiederherstellungsdatei von {{ maxBackupSizeText }}",

ui/src/i18n/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@
133133
"accessories.only_ui": "These settings are only for the Homebridge UI and <strong>will not be reflected in HomeKit</strong>.",
134134
"accessories.only_ui_2": "These options are unique to your Homebridge UI account.",
135135
"accessories.plugin": "Plugin",
136+
"accessories.protocol": "Protocol",
136137
"accessories.room_name": "Room Name",
137138
"accessories.service": "Service",
138139
"accessories.service_info": "Service Information",
@@ -144,7 +145,6 @@
144145
"accessories.support.rooms_2": "To rename an existing room, create a new room with the desired name and move the accessories to the new room.",
145146
"accessories.support.rooms_3": "To delete an existing room, move all its accessories to another room and refresh the page.",
146147
"accessories.title_rooms": "Rooms",
147-
"accessories.unique_id": "Unique ID",
148148
"backup.backup_delete_failed": "Backup deletion failed. See logs for details.",
149149
"backup.backup_download_failed": "Backup download failed.",
150150
"backup.backup_exceeds_max_size": "Backup ({{ backupSize }}) exceeds maximum restore file size of {{ maxBackupSizeText }}",

ui/src/i18n/es.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@
133133
"accessories.only_ui": "These settings are only for the Homebridge UI and <strong>will not be reflected in HomeKit</strong>.",
134134
"accessories.only_ui_2": "These options are unique to your Homebridge UI account.",
135135
"accessories.plugin": "Plugin",
136+
"accessories.protocol": "Protocol",
136137
"accessories.room_name": "Nombre de la habitación",
137138
"accessories.service": "Servicio",
138139
"accessories.service_info": "Información del Servicio",
@@ -144,7 +145,6 @@
144145
"accessories.support.rooms_2": "Para renombrar una habitación existente, crea una nueva habitación con el nombre deseado y mueve los accesorios a la nueva habitación.",
145146
"accessories.support.rooms_3": "Para eliminar una habitación existente, mueve todos sus accesorios a otra habitación y actualiza la página.",
146147
"accessories.title_rooms": "Rooms",
147-
"accessories.unique_id": "Unique ID",
148148
"backup.backup_delete_failed": "Error al eliminar la copia de seguridad. Consulta los registros para más detalles.",
149149
"backup.backup_download_failed": "Error al descargar la copia de seguridad",
150150
"backup.backup_exceeds_max_size": "La copia de seguridad ({{ backupSize }}) excede el tamaño máximo de archivo de restauración de {{ maxBackupSizeText }}",

ui/src/i18n/fi.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@
133133
"accessories.only_ui": "These settings are only for the Homebridge UI and <strong>will not be reflected in HomeKit</strong>.",
134134
"accessories.only_ui_2": "These options are unique to your Homebridge UI account.",
135135
"accessories.plugin": "Plugin",
136+
"accessories.protocol": "Protocol",
136137
"accessories.room_name": "Huoneen Nimi",
137138
"accessories.service": "Service",
138139
"accessories.service_info": "Service Information",
@@ -144,7 +145,6 @@
144145
"accessories.support.rooms_2": "To rename an existing room, create a new room with the desired name and move the accessories to the new room.",
145146
"accessories.support.rooms_3": "To delete an existing room, move all its accessories to another room and refresh the page.",
146147
"accessories.title_rooms": "Rooms",
147-
"accessories.unique_id": "Unique ID",
148148
"backup.backup_delete_failed": "Varmuuskopion poisto epäonnistui. Katso lokitiedoista tarkemmin.",
149149
"backup.backup_download_failed": "Varmuuskopion lataus epäonnistui",
150150
"backup.backup_exceeds_max_size": "Varmuuskopion koko ({{ backupSize }}) ylittää maksimikoon {{ maxBackupSizeText }}",

0 commit comments

Comments
 (0)