Skip to content

Commit dc94d06

Browse files
committed
fix: add conditional rendering for external links in PortfolioEntry component
1 parent 0299ae2 commit dc94d06

1 file changed

Lines changed: 35 additions & 34 deletions

File tree

src/components/portfolio/PortfolioEntry.tsx

Lines changed: 35 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -55,48 +55,49 @@ const PortfolioEntry = ({
5555
</h1>
5656
</div>
5757

58-
<div className="mt-6 rounded-2xl border border-outline-variant bg-surface-container-high p-4 lg:mt-0 lg:min-w-[320px]">
59-
<p className="label-mono mb-3 text-on-surface-muted">
60-
external_links
61-
</p>
62-
<div className="space-y-2">
63-
{demoUrl && (
64-
<Link
65-
href={demoUrl}
66-
className={externalLinkClassName}
67-
target="__blank"
68-
rel="noreferrer"
69-
>
70-
Open Demo
71-
</Link>
72-
)}
73-
{githubUrl && (
74-
<Link
75-
href={githubUrl}
76-
className={externalLinkClassName}
77-
target="_blank"
78-
rel="noreferrer"
79-
>
80-
View GitHub Code
81-
</Link>
82-
)}
83-
{urls &&
84-
urls.map((url, i) => (
58+
{(demoUrl || githubUrl || (urls && urls.length > 0)) && (
59+
<div className="mt-6 rounded-2xl border border-outline-variant bg-surface-container-high p-4 lg:mt-0 lg:min-w-[320px]">
60+
<p className="label-mono mb-3 text-on-surface-muted">
61+
external_links
62+
</p>
63+
<div className="space-y-2">
64+
{demoUrl && (
8565
<Link
86-
href={url}
87-
key={i}
66+
href={demoUrl}
67+
className={externalLinkClassName}
68+
target="__blank"
69+
rel="noreferrer"
70+
>
71+
Open Demo
72+
</Link>
73+
)}
74+
{githubUrl && (
75+
<Link
76+
href={githubUrl}
77+
className={externalLinkClassName}
8878
target="_blank"
8979
rel="noreferrer"
90-
className={`${externalLinkClassName} overflow-hidden overflow-ellipsis`}
9180
>
92-
Visit {url}
81+
View GitHub Code
9382
</Link>
94-
))}
83+
)}
84+
{urls &&
85+
urls.map((url, i) => (
86+
<Link
87+
href={url}
88+
key={i}
89+
target="_blank"
90+
rel="noreferrer"
91+
className={`${externalLinkClassName} overflow-hidden overflow-ellipsis`}
92+
>
93+
Visit {url}
94+
</Link>
95+
))}
96+
</div>
9597
</div>
96-
</div>
98+
)}
9799
</div>
98100
</section>
99-
100101
<PortfolioMedia
101102
title={title}
102103
images={images}

0 commit comments

Comments
 (0)