refactor: os.Exit'ing in main (#216)

Author: hugoh

internal/cmd.go

@@ -272,7 +272,7 @@ func setupColor(ctx context.Context, cmd *cli.Command) (context.Context, error)
 }
 
 // Cmd runs the CLI application with the given version string.
-func Cmd(version string) {
+func Cmd(version string) error {
 	var configFile string
 
 	configSource := altsrc.NewStringPtrSourcer(&configFile)
@@ -291,7 +291,5 @@ func Cmd(version string) {
 		},
 	}
 
-	if err := app.Run(context.Background(), os.Args); err != nil {
-		os.Exit(1)
-	}
+	return app.Run(context.Background(), os.Args) //nolint:wrapcheck
 }

internal/cmd_test.go

@@ -154,10 +154,13 @@ func TestCmd_Help(t *testing.T) {
 
 	defer func() { os.Args = oldArgs }()
 
+	var err error
+
 	out := testutil.CaptureOutput(t, func() {
-		Cmd("test-version")
+		err = Cmd("test-version")
 	})
 
+	require.NoError(t, err)
 	assert.Contains(t, out, "Utility to interact with T-Mobile Home Internet gateway")
 }
 
@@ -168,10 +171,14 @@ func TestCmd_Version(t *testing.T) {
 	defer func() { os.Args = oldArgs }()
 
 	testVersion := "test-version-123"
+
+	var err error
+
 	out := testutil.CaptureOutput(t, func() {
-		Cmd(testVersion)
+		err = Cmd(testVersion)
 	})
 
+	require.NoError(t, err)
 	assert.Contains(
 		t,
 		out,

main.go

@@ -2,11 +2,16 @@
 package main
 
 import (
+	"os"
+
 	"github.com/hugoh/tmhi-cli/internal"
 )
 
 var version = "dev"
 
 func main() {
-	internal.Cmd(version)
+	err := internal.Cmd(version)
+	if err != nil {
+		os.Exit(1)
+	}
 }