fix(transport): Make server builder more consitient#901
Merged
LucioFranco merged 2 commits intohyperium:masterfrom Feb 18, 2022
Merged
fix(transport): Make server builder more consitient#901LucioFranco merged 2 commits intohyperium:masterfrom
LucioFranco merged 2 commits intohyperium:masterfrom
Conversation
2e0dddb to
0f20b7e
Compare
Contributor
Author
|
I guess this might cause a silent breakage for code like this: let router = Server::builder();
router.timeout(Duration::from_secs(10));
|
Member
|
Yeah I think adding must use makes sense here then. If you want to go ahead and add that change here as well we can merge this. |
Contributor
Author
|
Done. |
Member
|
Can you rebase against master? I fixed the ci failure #914 |
…ilder transport/server/mod.rs exposes a Builder for the Server, and most of the Builder functions return Self (a change made for issue hyperium#115), but timeout returns mut& Self. This change makes timeout consistent with the rest of the Builder api by returning Self. Fixes: hyperium#900 Refs: hyperium#115
3e0391b to
b95117d
Compare
Contributor
Author
|
Thanks, rebased. |
LucioFranco
approved these changes
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See Issue #900
Solution
See Issue #900