Merged
Conversation
siladu
reviewed
Mar 17, 2025
Contributor
siladu
left a comment
There was a problem hiding this comment.
Maybe a test to prove the genesis hash matches 0xbbe312868b376a3001692a646dd2d7d1e4406380dfd86b98aa8a34d1557c971b as per https://github.com/eth-clients/hoodi/blob/main/README.md?plain=1#L30
Please also add a changelog entry.
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
f154e65 to
ff2357d
Compare
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
…t' into feat/issue-8426/add_hoodi_testnet
Contributor
|
Tested by syncing besu + teku with hoodi: |
garyschulte
approved these changes
Mar 17, 2025
garyschulte
pushed a commit
that referenced
this pull request
Mar 18, 2025
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
genesis file taken from: https://github.com/eth-clients/hoodi/blob/main/metadata/besu.json
bootnodes added from: https://github.com/eth-clients/hoodi/blob/main/metadata/enodes.yaml
Fixed Issue(s)
fixes #8426
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests