Skip to content

Hotfix 23.10.3-hotfix Log/Address Trielog rolling failure#6315

Merged
garyschulte merged 4 commits intobesu-eth:release-23.10.3from
garyschulte:bug/state-rolling-failure
Jan 7, 2024
Merged

Hotfix 23.10.3-hotfix Log/Address Trielog rolling failure#6315
garyschulte merged 4 commits intobesu-eth:release-23.10.3from
garyschulte:bug/state-rolling-failure

Conversation

@garyschulte
Copy link
Copy Markdown
Contributor

@garyschulte garyschulte commented Dec 19, 2023 •
edited
Loading

PR description

Hotfix release to address production issue with bonsai state rolling and repeated selfdestruct, see also #6359

Fixed Issue(s)

#6357

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 19, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@garyschulte garyschulte changed the title raise log rolling failure loglevel to error from debug Log/Address Trielog rolling failure Dec 19, 2023
@garyschulte garyschulte reopened this Dec 21, 2023
@garyschulte garyschulte force-pushed the bug/state-rolling-failure branch 2 times, most recently from 928c7f5 to a10ec47 Compare December 22, 2023 04:51
garyschulte and others added 2 commits January 6, 2024 14:47
@garyschulte
trigger a BWS if we do not have a valid worldstate available during fcU
2cf915b 
raise log rolling failure loglevel to error from debug

Signed-off-by: garyschulte <garyschulte@gmail.com>
@matkt @garyschulte
fixing on selfdestruct
c708891 
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
@garyschulte garyschulte force-pushed the bug/state-rolling-failure branch from 4808dd9 to c708891 Compare January 6, 2024 22:48
@garyschulte garyschulte changed the base branch from main to release-23.10.3 January 6, 2024 22:49
@garyschulte garyschulte changed the title Log/Address Trielog rolling failure Hotfix 23.10.4 Log/Address Trielog rolling failure Jan 6, 2024
@garyschulte
hotfix release commit
d453e50 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte marked this pull request as ready for review January 6, 2024 22:54
@garyschulte
use 23.10.3-hotfix moniker
4dfbe4f 
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte changed the title Hotfix 23.10.4 Log/Address Trielog rolling failure Hotfix 23.10.3-hotfix Log/Address Trielog rolling failure Jan 6, 2024
@garyschulte garyschulte merged commit f3751af into besu-eth:release-23.10.3 Jan 7, 2024
jflo pushed a commit to jflo/besu that referenced this pull request Jan 8, 2024
@garyschulte @jflo
Hotfix 23.10.3-hotfix Log/Address Trielog rolling failure (besu-eth#6315
e9ce09f 
)

* trigger a BWS if we do not have a valid worldstate available during fcU
raise log rolling failure loglevel to error from debug

Signed-off-by: garyschulte <garyschulte@gmail.com>

* fixing on selfdestruct

Signed-off-by: Karim Taam <karim.t2am@gmail.com>
jflo added a commit that referenced this pull request Jan 8, 2024
@jflo @garyschulte
Hotfix 23.10.3-hotfix Log/Address Trielog rolling failure (#6315) (#6371
ab4882c 
)

* trigger a BWS if we do not have a valid worldstate available during fcU
raise log rolling failure loglevel to error from debug



* fixing on selfdestruct

Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Co-authored-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte deleted the bug/state-rolling-failure branch January 24, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jflo jflo jflo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garyschulte @jflo @matkt
⚡