GitHub Actions CI/CD by jflo · Pull Request #6427 · besu-eth/besu

jflo · 2024-01-18T19:40:58Z

Proposed alternative to using CircleCI.

Please also consider the Design Doc available here: https://wiki.hyperledger.org/pages/viewpage.action?pageId=80774216

Fixes #6238

Signed-off-by: Justin Florentine <justin+github@florentine.us>

github-actions · 2024-01-18T19:41:14Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

macfarla · 2024-01-18T21:48:20Z

the unit test summary is pretty nice!

garyschulte

as discussed LGTM, pending addressing feedback

updated actions to versions that don't use deprecated versions of Node

Signed-off-by: RoboCopsGoneSock <158174948+RoboCopsGoneSock@users.noreply.github.com>

Update pr-checklist-on-open.yml

Signed-off-by: Justin Florentine <justin+github@florentine.us>

typo in pinned docker login action

Delete three files that appear to be work in progress development files. Signed-off-by: Danno Ferrin (shemnon) <danno.ferrin@shemnon.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>

Wire through configuration for the Prague fork, including speculative PragueGasCalculator, precompiles, genesis options, and implied forks in GenesisState. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>

* not recompute hash if not needed * Add memoize for the Supplier * Modify hashcode to only process keccak when slotkey is not defined * use single cache for keccak Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: ahamlat <ameziane.hamlat@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>

* info level log for pipeline abort * add depth protection Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>

Signed-off-by: Justin Florentine <justin+github@florentine.us>

Gha permmissioned

Signed-off-by: Justin Florentine <justin+github@florentine.us>

Implements a CI/CD pipeline using Github Actions, to replace the current CircleCI implementation. https://wiki.hyperledger.org/pages/viewpage.action?pageId=80774216 --------- Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: RoboCopsGoneSock <158174948+RoboCopsGoneSock@users.noreply.github.com> Signed-off-by: Danno Ferrin (shemnon) <danno.ferrin@shemnon.com> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: ahamlat <ameziane.hamlat@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: RoboCopsGoneSock <158174948+RoboCopsGoneSock@users.noreply.github.com> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Co-authored-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

Implements a CI/CD pipeline using Github Actions, to replace the current CircleCI implementation. https://wiki.hyperledger.org/pages/viewpage.action?pageId=80774216 --------- Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: RoboCopsGoneSock <158174948+RoboCopsGoneSock@users.noreply.github.com> Signed-off-by: Danno Ferrin (shemnon) <danno.ferrin@shemnon.com> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: ahamlat <ameziane.hamlat@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: RoboCopsGoneSock <158174948+RoboCopsGoneSock@users.noreply.github.com> Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Co-authored-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com>

jflo added 26 commits January 17, 2024 14:06

distracted mid-expression

f95bdaa

Signed-off-by: Justin Florentine <justin+github@florentine.us>

typo in expression

a01da79

Signed-off-by: Justin Florentine <justin+github@florentine.us>

allow pre-review to conclude prior to approval

e8fc83a

Signed-off-by: Justin Florentine <justin+github@florentine.us>

conditional should use needs result?

fdf7d38

Signed-off-by: Justin Florentine <justin+github@florentine.us>

single quotes?

823de9e

Signed-off-by: Justin Florentine <justin+github@florentine.us>

i wonder what happens with both success/fail statuses?

0001955

Signed-off-by: Justin Florentine <justin+github@florentine.us>

intentional test failure

d2398ea

Signed-off-by: Justin Florentine <justin+github@florentine.us>

fix intentional failed test

14b95a2

Signed-off-by: Justin Florentine <justin+github@florentine.us>

enables status required before merging

f0db898

Signed-off-by: Justin Florentine <justin+github@florentine.us>

default sha not always provided

4e30e3b

Signed-off-by: Justin Florentine <justin+github@florentine.us>

integration testing required

73498ce

Signed-off-by: Justin Florentine <justin+github@florentine.us>

testing default status check behavior with a broken test

015521d

Signed-off-by: Justin Florentine <justin+github@florentine.us>

testing default status check behavior with corrected test

9949869

Signed-off-by: Justin Florentine <justin+github@florentine.us>

might only need to manage pending status

b0cf8dd

Signed-off-by: Justin Florentine <justin+github@florentine.us>

lets see if a dummy job after a matrix works

435391b

Signed-off-by: Justin Florentine <justin+github@florentine.us>

lets see if a dummy job after a matrix works

9b50f2f

Signed-off-by: Justin Florentine <justin+github@florentine.us>

intentional test failure

59c227c

Signed-off-by: Justin Florentine <justin+github@florentine.us>

needing to name a job, not a workflow after a check is dumb

884366d

Signed-off-by: Justin Florentine <justin+github@florentine.us>

fail fast

804fcae

Signed-off-by: Justin Florentine <justin+github@florentine.us>

doing your own pending means clearing it. yuck

ecca195

Signed-off-by: Justin Florentine <justin+github@florentine.us>

can't depend on missing job

a88a17f

Signed-off-by: Justin Florentine <justin+github@florentine.us>

can't switch on an output you're not waiting for

93f4c83

Signed-off-by: Justin Florentine <justin+github@florentine.us>

manifest needs gradle

5c9c8b5

Signed-off-by: Justin Florentine <justin+github@florentine.us>

you will also need java ser

0df78ad

Signed-off-by: Justin Florentine <justin+github@florentine.us>

logging into dockerhub

4db11bf

Signed-off-by: Justin Florentine <justin+github@florentine.us>

test windows output

ecc5e1a

Signed-off-by: Justin Florentine <justin+github@florentine.us>

Merge branch 'main' into gha_permmissioned

66afea6

jflo mentioned this pull request Jan 18, 2024

[CI] publish tasks don't depend on test tasks #6412

Closed

jflo added 2 commits January 29, 2024 11:36

Merge branch 'main' into gha_permmissioned

aa91693

Merge branch 'main' into gha_permmissioned

94aacf6

garyschulte approved these changes Jan 29, 2024

View reviewed changes

Merge branch 'main' into gha_permmissioned

2591527

fab-10 approved these changes Jan 30, 2024

View reviewed changes

jflo and others added 6 commits January 30, 2024 08:38

Merge pull request #42 from jflo/gha_permmissioned

a46e642

updated actions to versions that don't use deprecated versions of Node

Update pr-checklist-on-open.yml

cb9f78f

Signed-off-by: RoboCopsGoneSock <158174948+RoboCopsGoneSock@users.noreply.github.com>

Merge pull request #46 from RoboCopsGoneSock/RoboCopsGoneSock-patch-1

157b62e

Update pr-checklist-on-open.yml

typo in pinned docker login action

ce7f9b0

Signed-off-by: Justin Florentine <justin+github@florentine.us>

Merge branch 'main' into gha_permmissioned

e7a951c

Merge pull request #47 from jflo/gha_permmissioned

df9ecae

typo in pinned docker login action

jflo force-pushed the gha_permmissioned branch 2 times, most recently from 16e2879 to 5e6693a Compare January 30, 2024 23:15

shemnon and others added 6 commits January 30, 2024 18:15

Delete development artifacts (besu-eth#6487)

c6b7795

Delete three files that appear to be work in progress development files. Signed-off-by: Danno Ferrin (shemnon) <danno.ferrin@shemnon.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>

info level log for pipeline abort (besu-eth#6459)

3d9d6e5

* info level log for pipeline abort * add depth protection Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>

permission request on manifest

074c4dc

Signed-off-by: Justin Florentine <justin+github@florentine.us>

permission needed to comment on pr

2101553

Signed-off-by: Justin Florentine <justin+github@florentine.us>

jflo force-pushed the gha_permmissioned branch from 5e6693a to 2101553 Compare January 30, 2024 23:15

jflo added 3 commits January 30, 2024 18:38

Merge pull request #49 from jflo/gha_permmissioned

d951caa

Gha permmissioned

align archive versions with docker images, if release version specified

12bcb11

Signed-off-by: Justin Florentine <justin+github@florentine.us>

try another permission

f64398f

Signed-off-by: Justin Florentine <justin+github@florentine.us>

jflo force-pushed the gha_permmissioned branch from 5e0d3e1 to f64398f Compare January 31, 2024 00:13

jflo added 2 commits January 30, 2024 20:03

Merge branch 'main' into gha_permmissioned

4f7c59a

Signed-off-by: Justin Florentine <justin+github@florentine.us>

Merge branch 'main' into gha_permmissioned

96ca4fa

jflo enabled auto-merge (squash) January 31, 2024 13:19

jflo merged commit 9cb6600 into besu-eth:main Jan 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Actions CI/CD#6427

GitHub Actions CI/CD#6427
jflo merged 373 commits intobesu-eth:mainfrom
jflo:gha_permmissioned

jflo commented Jan 18, 2024

Uh oh!

github-actions bot commented Jan 18, 2024

Uh oh!

macfarla commented Jan 18, 2024

Uh oh!

garyschulte left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

jflo commented Jan 18, 2024

Uh oh!

github-actions bot commented Jan 18, 2024

Uh oh!

macfarla commented Jan 18, 2024

Uh oh!

garyschulte left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants