Conversation
Update tracing and evm tool * Intrinsic gas is optional in EVMTool * For call series, also charge the gas given to the next call level Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
|
evm/src/main/java/org/hyperledger/besu/evm/tracing/StandardJsonTracer.java
Show resolved
Hide resolved
Wire into the debug_ series calls, but not the trace_ series calls. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
| addressList.add(sender); | ||
| addressList.add(contract); |
There was a problem hiding this comment.
What does this change mean in this PR?
There was a problem hiding this comment.
EIP-2929 says the sender and contract address are pre-warmed. The transaction handler does that, but the evm tool has it's own bootstrap logic and needs to pre-warm them.
Gabriel-Trintinalia
left a comment
Gabriel-Trintinalia
left a comment
There was a problem hiding this comment.
LGTM, Would you be able to add some comments on how additionalCallGas works either in the AbstractTraceCall or in the DebugOperationTracer and/or when it makes sense to use it? It could help future development to use this flag correctly.
ahamlat
left a comment
ahamlat
left a comment
There was a problem hiding this comment.
LGTM. From what I see, this pull request makes two separate improvements. The change in tracing affects only calls frames in debug trace RPC methods, not "Parity" style RPC tracing calls. I'm assuming this difference is more about the design or specification choice, correct?
| traceFrame(validCallFrame(), new TraceOptions(false, false, false), true); | ||
| assertThat(traceFrame.getGasCost()).isEqualTo(OptionalLong.of(1020L)); | ||
| } | ||
|
|
There was a problem hiding this comment.
It could be interesting to add a test with a frame that is not a call frame, set additionalCallGas to true and verify that gasCost in the frame is not updated with additionalCallGas.
There was a problem hiding this comment.
test added. validMessageFrame with opposite flags, asserting it's the same.
documentation tests Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Update tracing and evm tool * Intrinsic gas is optional in EVMTool * For call series, also charge the gas given to the next call level for debug_ series calls. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
3 participants
PR description
Update tracing and evm tool
Fixed Issue(s)
Fixes #6523