Fix parsing gasLimit parameter when its value is > Long.MAX_VALUE#7116
Merged
macfarla merged 2 commits intobesu-eth:mainfrom May 16, 2024
Merged
Conversation
fab-10
changed the title
gasLimit parameter when its value is > Long.MAX_VALUE
fab-10
changed the title
gasLimit parameter when its value is > Long.MAX_VALUEgasLimit parameter when its value is > Long.MAX_VALUE
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
fix-call-parameters-max-gas-limit-value
branch
from
0df9e68 to
d821ac1
Compare
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
May 28, 2024
…su-eth#7116) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
…su-eth#7116) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 10, 2024
…su-eth#7116) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
When calling
eth_estimateGaswith thegasfield set to the maximum value0xffffffffffffffffor anything greater than0x7fffffffffffffff, the endpoint returns and error says parameters are invalid, due to the fact that we use alongto fix the value, and it cannot fit these values.This is not the correct behavior, so the fix is to cap the value to Long.MAX_VALUE, in case the input field has a greater value, since in practice gas limit will not reach such value.
The deserializer has been rename to
GasDeserializersince it is now specific to gas and not generic long values.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests