Honor block number or tag parameter in eth_estimateGas and eth_createAccessList#7502
Merged
fab-10 merged 2 commits intobesu-eth:mainfrom Sep 5, 2024
Merged
Conversation
e0328b0 to
b0f901d
Compare
…AccessList Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
b0f901d to
677f5ee
Compare
jflo
approved these changes
Sep 5, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…AccessList
PR description
Fix to read and used the block tag or number parameter in
eth_estimateGasandeth_createAccessListinstead of always using thelatestblock.Fixed Issue(s)
fixes #7414
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests