Fix debug_traceCall to handle underpriced transactions

[7suyash7]

Fixes: #7503 where debug_traceCall was failing due to gas price checks, while eth_call was succeeding.

Output from debug_traceCall

curl --data '{               
  "jsonrpc": "2.0",
  "id": 0,
  "method": "debug_traceCall",
  "params": [ {
    "to": "0x0aae40965e6800cd9b1f4b05ff21581047e3f91e",
    "data": "0x000000000000000000000000000000000000000000000000000000000001A00E"
  }, "latest"]
}' -H "Content-Type: application/json" -X POST http://127.0.0.1:8545
{"jsonrpc":"2.0","id":0,"result":{"gas":21164,"failed":false,"returnValue":"","structLogs":[{"pc":0,"op":"STOP","gas":7978836,"gasCost":0,"depth":1,"stack":[],"memory":[],"storage":{},"reason":null}]}}

[jframe]

This method doesn't appear to be used anywhere in DebugTraceCall

[7suyash7]

Hi, yeah, I just removed it, I also removed the errorResponse method. Weirdly, the compiler caught that errorResponse was not being used anywhere when I tried compiling and building after removing resultByBlockHeader right now but didn't catch resultByBlockHeader...

[fab-10]

This fix the issue with debug_traceCall, but since it part of a group of RPC methods extending the AbstractTraceByBlock class, it is better to review if the issue affects other methods in the group, and compare the behavior with other clients to be sure there are not other differences.

[7suyash7]

This fix the issue with debug_traceCall, but since it part of a group of RPC methods extending the AbstractTraceByBlock class, it is better to review if the issue affects other methods in the group, and compare the behavior with other clients to be sure there are not other differences.

@fab-10 What do you expect the next steps to be here?

[fab-10]

@7suyash7 first I suggest to review if trace_call, trace_callMany and trace_rawTransaction that extend AbstractTraceByBlock like debug_traceCall have a similar issue and depending on that uniform the fix across all of them.

[7suyash7]

@7suyash7 first I suggest to review if trace_call, trace_callMany and trace_rawTransaction that extend AbstractTraceByBlock like debug_traceCall have a similar issue and depending on that uniform the fix across all of them.

Hi, @fab-10,
As you suggested, I've checked if trace_call, trace_callMany and trace_rawTransaction have a similar issue to what, debug_traceCall had, I just checked them and they look like they are working fine after testing.

Here is the output from each one of them:

1. trace_call:

 curl -X POST --data '{
  "jsonrpc":"2.0",
  "method":"trace_call",
  "params":[
    {
      "to": "0x0aae40965e6800cd9b1f4b05ff21581047e3f91e",
      "data": "0x000000000000000000000000000000000000000000000000000000000001A00E"
    },
    ["trace"],
    "latest"
  ],
  "id":1
}' http://localhost:8545
{"jsonrpc":"2.0","id":1,"result":{"output":"0x","stateDiff":null,"trace":[{"action":{"callType":"call","from":"0x0000000000000000000000000000000000000000","gas":"0x9fad54","input":"0x000000000000000000000000000000000000000000000000000000000001a00e","to":"0x0aae40965e6800cd9b1f4b05ff21581047e3f91e","value":"0x0"},"result":{"gasUsed":"0x0","output":"0x"},"subtraces":0,"traceAddress":[],"type":"call"}],"vmTrace":null}}

2. trace_callMany

 curl -X POST --data '{
  "jsonrpc":"2.0",
  "method":"trace_callMany",
  "params":[
    [
      [
        {
          "to": "0x0aae40965e6800cd9b1f4b05ff21581047e3f91e",
          "data": "0x000000000000000000000000000000000000000000000000000000000001A00E"
        },
        ["trace"]
      ]
    ],
    "latest"
  ],
  "id":1
}' http://localhost:8545
{"jsonrpc":"2.0","id":1,"result":[{"output":"0x","stateDiff":null,"trace":[{"action":{"callType":"call","from":"0x0000000000000000000000000000000000000000","gas":"0x9fad54","input":"0x000000000000000000000000000000000000000000000000000000000001a00e","to":"0x0aae40965e6800cd9b1f4b05ff21581047e3f91e","value":"0x0"},"result":{"gasUsed":"0x0","output":"0x"},"subtraces":0,"traceAddress":[],"type":"call"}],"vmTrace":null}]}

3. trace_rawTransaction

curl -X POST --data '{
  "jsonrpc":"2.0",
  "method":"trace_rawTransaction",
  "params":["0x01f86f8205390184ee6b2800825208940aae40965e6800cd9b1f4b05ff21581047e3f91e88016345785d8a000080c001a05c91601be0a97bcf8bf8dee799ed5fb785f9bea38bd1fa899d047cefb553b4c2a06b417fb534a24c1bcb63301ea462b982b2454dedf624b6195e6805315429f130", ["trace"]],
  "id":1
}' http://localhost:8545
{"jsonrpc":"2.0","id":1,"result":{"output":"0x","stateDiff":null,"trace":[{"action":{"callType":"call","from":"0x99ac17ce1163d1de38f6fa64d5aa96cbb19c0c55","gas":"0x0","input":"0x","to":"0x0aae40965e6800cd9b1f4b05ff21581047e3f91e","value":"0x16345785d8a0000"},"result":{"gasUsed":"0x0","output":"0x"},"subtraces":0,"traceAddress":[],"type":"call"}],"vmTrace":null}}

Let me know if you need further information or want me to conduct additional tests.

[fab-10]

Thanks @7suyash7 for checking, I think that is enough and the change can be limited to this call, could you just add a test case and a changelog entry to complete the fix?

[7suyash7]

Thanks @7suyash7 for checking, I think that is enough and the change can be limited to this call, could you just add a test case and a changelog entry to complete the fix?

@fab-10 I just did, can you please check?

[fab-10]

LGTM