Revise the approach for setting level_compaction_dynamic_level_bytes#8037
Merged
ahamlat merged 13 commits intobesu-eth:mainfrom Dec 18, 2024
Merged
Conversation
…ime to open the database Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
jflo
approved these changes
Dec 17, 2024
matkt
reviewed
Dec 17, 2024
...perledger/besu/plugin/services/storage/rocksdb/segmented/RocksDBColumnarKeyValueStorage.java
Show resolved
Hide resolved
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
daniellehrner
pushed a commit
to daniellehrner/besu
that referenced
this pull request
Dec 18, 2024
…esu-eth#8037) * Create a RocksDB opener that display a warning if it takes too much time to open the database * Change the strategy levelCompactionDynamicLevelBytes is set Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
pullurib
pushed a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…esu-eth#8037) * Create a RocksDB opener that display a warning if it takes too much time to open the database * Change the strategy levelCompactionDynamicLevelBytes is set Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
We noticed with the upgrade from RocksDB from 8.3.2 to 9.7.3 that the defaults on LeveledCompaction are changed to reduce space amplification. This changes triggered big compactions depending on the nodes when opening RocksDB databse. This is related to change in the value of this parameter
level_compaction_dynamic_level_bytes, changed from false to true.This PR modify the logic for determining
level_compaction_dynamic_level_byteslevel_compaction_dynamic_level_bytes=falseif the node is not upgraded yet to 24.12.0, 24.12.1 or 24.12.2) (i.e no compaction)level_compaction_dynamic_level_bytes=true, as the compaction already happenedlevel_compaction_dynamic_level_bytes=trueTested with success :
level_compaction_dynamic_level_bytesset to false (no compaction)level_compaction_dynamic_level_bytesset to true (compaction already happened, so no more overhead)level_compaction_dynamic_level_bytesset to trueTo detect similar issues in the future, we added a warning log if database opening exceeds 60 seconds.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests