[FAB-7346] Make IsChaincodeInstalled a private method

In fabric-txn/resmgmtclient, IsChaincodeInstalled was incorrectly
exported (see related issue for details). This change makes the method
private and updates its uses accordingly.

Tested via make all without error.

Change-Id: I9c684ad7d73eb2b171c2f8b57a61157637ea2768
Signed-off-by: Nick Chang-Fong <nick@diid.today>

Author: Nick Chang-Fong

pkg/fabric-txn/resmgmtclient/resmgmt.go

@@ -213,8 +213,8 @@ func (rc *ResourceMgmtClient) calculateTargets(discovery fab.DiscoveryService, p
 	return targets, nil
 }
 
-// IsChaincodeInstalled verify if chaincode is installed on peer
-func (rc *ResourceMgmtClient) IsChaincodeInstalled(req resmgmt.InstallCCRequest, peer fab.Peer) (bool, error) {
+// isChaincodeInstalled verify if chaincode is installed on peer
+func (rc *ResourceMgmtClient) isChaincodeInstalled(req resmgmt.InstallCCRequest, peer fab.Peer) (bool, error) {
 	chaincodeQueryResponse, err := rc.client.QueryInstalledChaincodes(peer)
 	if err != nil {
 		return false, err
@@ -274,7 +274,7 @@ func (rc *ResourceMgmtClient) InstallCCWithOpts(req resmgmt.InstallCCRequest, op
 	newTargets := make([]fab.Peer, 0)
 
 	for _, target := range targets {
-		installed, err := rc.IsChaincodeInstalled(req, target)
+		installed, err := rc.isChaincodeInstalled(req, target)
 		if err != nil {
 			// Add to responses with unable to verify error message
 			response := resmgmt.InstallCCResponse{Target: target.URL(), Err: errors.Errorf("unable to verify if cc is installed on %s", target.URL())}

pkg/fabric-txn/resmgmtclient/resmgmt_test.go

@@ -257,7 +257,7 @@ func TestIsChaincodeInstalled(t *testing.T) {
 	req := resmgmt.InstallCCRequest{Name: "name", Version: "version", Path: "path"}
 
 	// Test chaincode installed (valid peer)
-	installed, err := rc.IsChaincodeInstalled(req, peer)
+	installed, err := rc.isChaincodeInstalled(req, peer)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -269,7 +269,7 @@ func TestIsChaincodeInstalled(t *testing.T) {
 	req = resmgmt.InstallCCRequest{Name: "ID", Version: "v0", Path: "path"}
 
 	// Test chaincode installed
-	installed, err = rc.IsChaincodeInstalled(req, peer)
+	installed, err = rc.isChaincodeInstalled(req, peer)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -278,7 +278,7 @@ func TestIsChaincodeInstalled(t *testing.T) {
 	}
 
 	// Test error retrieving installed cc info (peer is nil)
-	_, err = rc.IsChaincodeInstalled(req, nil)
+	_, err = rc.isChaincodeInstalled(req, nil)
 	if err == nil {
 		t.Fatalf("Should have failed with error in get installed chaincodes")
 	}