Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Commit 22e666e

Browse files
committed
[FAB-6763] Give protos own namespace
Change-Id: Id0d96d42a2fec24c97be5af79e3e83917a8a79c3 Signed-off-by: Divyank Katira <Divyank.Katira@securekey.com>
1 parent 23ec481 commit 22e666e

File tree

24 files changed

+175
-131
lines changed

24 files changed

+175
-131
lines changed

internal/github.com/hyperledger/fabric/protos/orderer/ab.pb.go

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

scripts/third_party_pins/fabric/apply_fabric_protos.sh

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
IMPORT_SUBSTS=($IMPORT_SUBSTS)
1313

1414
GOIMPORTS_CMD=goimports
15+
NAMESPACE_PREFIX="sdk."
1516

1617
declare -a PKGS=(
1718
"protos/common"
@@ -69,6 +70,39 @@ WORKING_DIR=$TMP_PROJECT_PATH FILES="${FILES[@]}" IMPORT_SUBSTS="${IMPORT_SUBSTS
6970
echo "Inserting modification notice ..."
7071
WORKING_DIR=$TMP_PROJECT_PATH FILES="${FILES[@]}" ALLOW_NONE_LICENSE_ID="true" scripts/third_party_pins/common/apply_header_notice.sh
7172

73+
echo "Changing proto registration paths to be unique"
74+
for i in "${FILES[@]}"
75+
do
76+
if [[ ${i} == "protos/common"* ]]; then
77+
sed -i'' -e "/proto.RegisterType/s/common/${NAMESPACE_PREFIX}common/g" "${TMP_PROJECT_PATH}/${i}"
78+
sed -i'' -e "/proto.RegisterEnum/s/common/${NAMESPACE_PREFIX}common/g" "${TMP_PROJECT_PATH}/${i}"
79+
fi
80+
if [[ ${i} == "protos/ledger/rwset/rwset.pb.go" ]]; then
81+
sed -i'' -e "/proto.RegisterType/s/rwset/${NAMESPACE_PREFIX}rwset/g" "${TMP_PROJECT_PATH}/${i}"
82+
sed -i'' -e "/proto.RegisterEnum/s/rwset/${NAMESPACE_PREFIX}rwset/g" "${TMP_PROJECT_PATH}/${i}"
83+
fi
84+
if [[ ${i} == "protos/ledger/rwset/kvrwset/kv_rwset.pb.go" ]]; then
85+
sed -i'' -e "/proto.RegisterType/s/kvrwset/${NAMESPACE_PREFIX}kvrwset/g" "${TMP_PROJECT_PATH}/${i}"
86+
sed -i'' -e "/proto.RegisterEnum/s/kvrwset/${NAMESPACE_PREFIX}kvrwset/g" "${TMP_PROJECT_PATH}/${i}"
87+
fi
88+
if [[ ${i} == "protos/msp"* ]]; then
89+
sed -i'' -e "/proto.RegisterType/s/msp/${NAMESPACE_PREFIX}msp/g" "${TMP_PROJECT_PATH}/${i}"
90+
sed -i'' -e "/proto.RegisterEnum/s/msp/${NAMESPACE_PREFIX}msp/g" "${TMP_PROJECT_PATH}/${i}"
91+
fi
92+
if [[ ${i} == "protos/msp/msp_principal.pb.go" ]]; then
93+
sed -i'' -e "/proto.RegisterType/s/common/${NAMESPACE_PREFIX}common/g" "${TMP_PROJECT_PATH}/${i}"
94+
sed -i'' -e "/proto.RegisterEnum/s/common/${NAMESPACE_PREFIX}common/g" "${TMP_PROJECT_PATH}/${i}"
95+
fi
96+
if [[ ${i} == "protos/orderer"* ]]; then
97+
sed -i'' -e "/proto.RegisterType/s/orderer/${NAMESPACE_PREFIX}orderer/g" "${TMP_PROJECT_PATH}/${i}"
98+
sed -i'' -e "/proto.RegisterEnum/s/orderer/${NAMESPACE_PREFIX}orderer/g" "${TMP_PROJECT_PATH}/${i}"
99+
fi
100+
if [[ ${i} == "protos/peer"* ]]; then
101+
sed -i'' -e "/proto.RegisterType/s/protos/${NAMESPACE_PREFIX}protos/g" "${TMP_PROJECT_PATH}/${i}"
102+
sed -i'' -e "/proto.RegisterEnum/s/protos/${NAMESPACE_PREFIX}protos/g" "${TMP_PROJECT_PATH}/${i}"
103+
fi
104+
done
105+
72106
# Copy patched project into internal paths
73107
echo "Copying patched upstream project into working directory ..."
74108
for i in "${FILES[@]}"

scripts/third_party_pins/fabric/apply_fabric_protos_internal.sh

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ IMPORT_SUBSTS=($IMPORT_SUBSTS)
1313

1414
GOIMPORTS_CMD=goimports
1515
GOFILTER_CMD="go run scripts/_go/cmd/gofilter/gofilter.go"
16+
NAMESPACE_PREFIX="sdk."
1617

1718
declare -a PKGS=(
1819
"protos/utils"
@@ -53,7 +54,7 @@ gofilter() {
5354
$GOFILTER_CMD -filename "${TMP_PROJECT_PATH}/${FILTER_FILENAME}.bak" \
5455
-filters fn -fn "$FILTER_FN" \
5556
> "${TMP_PROJECT_PATH}/${FILTER_FILENAME}"
56-
}
57+
}
5758

5859
echo "Filtering Go sources for allowed functions ..."
5960
FILTER_FILENAME="protos/utils/commonutils.go"
@@ -82,6 +83,15 @@ echo "Inserting modification notice ..."
8283
WORKING_DIR=$TMP_PROJECT_PATH FILES="${NPBFILES[@]}" scripts/third_party_pins/common/apply_header_notice.sh
8384
WORKING_DIR=$TMP_PROJECT_PATH FILES="${PBFILES[@]}" ALLOW_NONE_LICENSE_ID="true" scripts/third_party_pins/common/apply_header_notice.sh
8485

86+
echo "Changing proto registration paths to be unique"
87+
for i in "${FILES[@]}"
88+
do
89+
if [[ ${i} == "protos/orderer"* ]]; then
90+
sed -i'' -e "/proto.RegisterType/s/orderer/${NAMESPACE_PREFIX}orderer/g" "${TMP_PROJECT_PATH}/${i}"
91+
sed -i'' -e "/proto.RegisterEnum/s/orderer/${NAMESPACE_PREFIX}orderer/g" "${TMP_PROJECT_PATH}/${i}"
92+
fi
93+
done
94+
8595
# Copy patched project into internal paths
8696
echo "Copying patched upstream project into working directory ..."
8797
for i in "${FILES[@]}"

third_party/github.com/hyperledger/fabric/protos/common/common.pb.go

Lines changed: 15 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

third_party/github.com/hyperledger/fabric/protos/common/configtx.pb.go

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

third_party/github.com/hyperledger/fabric/protos/common/configuration.pb.go

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

third_party/github.com/hyperledger/fabric/protos/common/ledger.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

third_party/github.com/hyperledger/fabric/protos/common/policies.pb.go

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

third_party/github.com/hyperledger/fabric/protos/ledger/rwset/kvrwset/kv_rwset.pb.go

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

third_party/github.com/hyperledger/fabric/protos/ledger/rwset/rwset.pb.go

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)