Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Commit 28ed3d2

Browse files
committed
[FABG-714] fix typoes
Change-Id: Id982afa80dc6bd3f74ca81b5dc9c13677ee99c7e Signed-off-by: ping40 <norberthu30@gmail.com>
1 parent 708bb63 commit 28ed3d2

File tree

1 file changed

+15
-14
lines changed

1 file changed

+15
-14
lines changed

pkg/core/logging/metadata/callerInfo_test.go

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,23 @@ package metadata
99
import (
1010
"testing"
1111

12-
"github.com/hyperledger/fabric-sdk-go/pkg/core/logging/api"
1312
"github.com/stretchr/testify/assert"
13+
14+
"github.com/hyperledger/fabric-sdk-go/pkg/core/logging/api"
1415
)
1516

1617
func TestCallerInfoSetting(t *testing.T) {
1718

1819
sampleCallerInfoSetting := CallerInfo{}
1920
samppleModuleName := "sample-module-name"
2021

22+
//By default caller info should be enabled if not set
23+
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.DEBUG), "Callerinfo supposed to be enabled for this level")
24+
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.INFO), "Callerinfo supposed to be enabled for this level")
25+
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.WARNING), "Callerinfo supposed to be enabled for this level")
26+
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.ERROR), "Callerinfo supposed to be enabled for this level")
27+
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.CRITICAL), "Callerinfo supposed to be enabled for this level")
28+
2129
sampleCallerInfoSetting.ShowCallerInfo(samppleModuleName, api.DEBUG)
2230
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.DEBUG), "Callerinfo supposed to be enabled for this level")
2331

@@ -27,18 +35,11 @@ func TestCallerInfoSetting(t *testing.T) {
2735
//Reset existing caller info setting
2836
sampleCallerInfoSetting.showcaller = nil
2937

30-
//By default caller info should be disabled if not set
31-
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.DEBUG), "Callerinfo supposed to be enabled for this level")
32-
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.INFO), "Callerinfo supposed to be disabled for this level")
33-
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.WARNING), "Callerinfo supposed to be disabled for this level")
34-
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.ERROR), "Callerinfo supposed to be disabled for this level")
35-
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleModuleName, api.CRITICAL), "Callerinfo supposed to be disabled for this level")
36-
37-
//By default caller info should be disabled if module name not found
38+
//By default caller info should be enabled for any module name
3839
samppleInvalidModuleName := "sample-module-name-doesnt-exists"
39-
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleInvalidModuleName, api.INFO), "Callerinfo supposed to be disabled for this level")
40-
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleInvalidModuleName, api.WARNING), "Callerinfo supposed to be disabled for this level")
41-
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleInvalidModuleName, api.ERROR), "Callerinfo supposed to be disabled for this level")
42-
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleInvalidModuleName, api.CRITICAL), "Callerinfo supposed to be disabled for this level")
43-
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleInvalidModuleName, api.DEBUG), "Callerinfo supposed to be disabled for this level")
40+
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleInvalidModuleName, api.INFO), "Callerinfo supposed to be enabled for this level")
41+
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleInvalidModuleName, api.WARNING), "Callerinfo supposed to be enabled for this level")
42+
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleInvalidModuleName, api.ERROR), "Callerinfo supposed to be enabled for this level")
43+
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleInvalidModuleName, api.CRITICAL), "Callerinfo supposed to be enabled for this level")
44+
assert.True(t, sampleCallerInfoSetting.IsCallerInfoEnabled(samppleInvalidModuleName, api.DEBUG), "Callerinfo supposed to be enabled for this level")
4445
}

0 commit comments

Comments
 (0)