[FAB-9095] Panic when no channel policies defined

Change-Id: Iaae22889ee0991975ad6c33888998a5a5ae1f687
Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>

Author: Firas Qutishat

pkg/fab/chconfig/chconfig.go

@@ -218,22 +218,27 @@ func (c *ChannelConfig) resolveOptsFromConfig(ctx context.Client) error {
 	}
 
 	if c.opts.MaxTargets == 0 {
-		c.opts.MaxTargets = chSdkCfg.Policies.QueryChannelConfig.MaxTargets
+		if chSdkCfg != nil && &chSdkCfg.Policies != nil && &chSdkCfg.Policies.QueryChannelConfig != nil {
+			c.opts.MaxTargets = chSdkCfg.Policies.QueryChannelConfig.MaxTargets
+		}
 		if c.opts.MaxTargets == 0 {
 			c.opts.MaxTargets = defaultMaxTargets
 		}
 	}
 
 	if c.opts.MinResponses == 0 {
-		c.opts.MinResponses = chSdkCfg.Policies.QueryChannelConfig.MinResponses
+		if chSdkCfg != nil && &chSdkCfg.Policies != nil && &chSdkCfg.Policies.QueryChannelConfig != nil {
+			c.opts.MinResponses = chSdkCfg.Policies.QueryChannelConfig.MinResponses
+		}
 		if c.opts.MinResponses == 0 {
 			c.opts.MinResponses = defaultMinResponses
 		}
 	}
 
 	if c.opts.RetryOpts.RetryableCodes == nil {
-		c.opts.RetryOpts = chSdkCfg.Policies.QueryChannelConfig.RetryOpts
-
+		if chSdkCfg != nil && &chSdkCfg.Policies != nil && &chSdkCfg.Policies.QueryChannelConfig != nil {
+			c.opts.RetryOpts = chSdkCfg.Policies.QueryChannelConfig.RetryOpts
+		}
 		if c.opts.RetryOpts.Attempts == 0 {
 			c.opts.RetryOpts.Attempts = retry.DefaultAttempts
 		}

pkg/fab/chconfig/chconfig_test.go

@@ -222,6 +222,26 @@ func TestResolveOptsFromConfig(t *testing.T) {
 	assert.False(t, mockConfig.called, "config.ChannelConfig() should not be used by resolve opts function once opts are loaded")
 }
 
+func TestResolveOptsDefaultValues(t *testing.T) {
+	user := mspmocks.NewMockSigningIdentity("test", "test")
+	ctx := mocks.NewMockContext(user)
+
+	mockConfig := &customMockConfig{MockConfig: &mocks.MockConfig{}, chConfig: nil}
+	ctx.SetConfig(mockConfig)
+
+	channelConfig, err := New(channelID, WithPeers([]fab.Peer{}))
+	if err != nil {
+		t.Fatal("Failed to create channel config")
+	}
+	err = channelConfig.resolveOptsFromConfig(ctx)
+	if err != nil {
+		t.Fatal("Failed to resolve opts from config")
+	}
+	assert.True(t, channelConfig.opts.MaxTargets == 2, "supposed to be loaded once opts resolved from config")
+	assert.True(t, channelConfig.opts.MinResponses == 1, "supposed to be loaded once opts resolved from config")
+	assert.True(t, channelConfig.opts.RetryOpts.RetryableCodes != nil, "supposed to be loaded once opts resolved from config")
+}
+
 func setupTestContext() context.Client {
 	user := mspmocks.NewMockSigningIdentity("test", "test")
 	ctx := mocks.NewMockContext(user)