Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Commit cc16a4a

Browse files
committed
[FAB-8935] Update TargetFilter in resmgmt to fab import
Change-Id: I3799796714551e6a7f5d99b7184415ac797ad0d7 Signed-off-by: Troy Ronda <troy@troyronda.com>
1 parent b2c76cd commit cc16a4a

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

pkg/client/resmgmt/opts.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ func WithTargetURLs(urls ...string) RequestOption {
5353
}
5454

5555
// WithTargetFilter enables a target filter for the request.
56-
func WithTargetFilter(targetFilter TargetFilter) RequestOption {
56+
func WithTargetFilter(targetFilter fab.TargetFilter) RequestOption {
5757
return func(ctx context.Client, opts *requestOptions) error {
5858
opts.TargetFilter = targetFilter
5959
return nil

pkg/client/resmgmt/resmgmt.go

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,6 @@ import (
3535
"github.com/pkg/errors"
3636
)
3737

38-
// TargetFilter allows for filtering target peers
39-
type TargetFilter interface {
40-
// Accept returns true if peer should be included in the list of target peers
41-
Accept(peer fab.Peer) bool
42-
}
43-
4438
// InstallCCRequest contains install chaincode request parameters
4539
type InstallCCRequest struct {
4640
Name string
@@ -79,7 +73,7 @@ type UpgradeCCRequest struct {
7973
//requestOptions contains options for operations performed by ResourceMgmtClient
8074
type requestOptions struct {
8175
Targets []fab.Peer // target peers
82-
TargetFilter TargetFilter // target filter
76+
TargetFilter fab.TargetFilter // target filter
8377
Orderer fab.Orderer // use specific orderer
8478
Timeouts map[core.TimeoutType]time.Duration //timeout options for resmgmt operations
8579
ParentContext reqContext.Context //parent grpc context for resmgmt operations
@@ -103,7 +97,7 @@ var logger = logging.NewLogger("fabsdk/client")
10397
type Client struct {
10498
ctx context.Client
10599
discovery fab.DiscoveryService // global discovery service (detects all peers on the network)
106-
filter TargetFilter
100+
filter fab.TargetFilter
107101
}
108102

109103
// mspFilter is default filter
@@ -120,7 +114,7 @@ func (f *mspFilter) Accept(peer fab.Peer) bool {
120114
type ClientOption func(*Client) error
121115

122116
// WithDefaultTargetFilter option to configure new
123-
func WithDefaultTargetFilter(filter TargetFilter) ClientOption {
117+
func WithDefaultTargetFilter(filter fab.TargetFilter) ClientOption {
124118
return func(rmc *Client) error {
125119
rmc.filter = filter
126120
return nil
@@ -221,7 +215,7 @@ func (rc *Client) JoinChannel(channelID string, options ...RequestOption) error
221215
}
222216

223217
// filterTargets is helper method to filter peers
224-
func filterTargets(peers []fab.Peer, filter TargetFilter) []fab.Peer {
218+
func filterTargets(peers []fab.Peer, filter fab.TargetFilter) []fab.Peer {
225219

226220
if filter == nil {
227221
return peers
@@ -254,7 +248,7 @@ func (rc *Client) getDefaultTargets(discovery fab.DiscoveryService) ([]fab.Peer,
254248
}
255249

256250
// calculateTargets calculates targets based on targets and filter
257-
func (rc *Client) calculateTargets(discovery fab.DiscoveryService, peers []fab.Peer, filter TargetFilter) ([]fab.Peer, error) {
251+
func (rc *Client) calculateTargets(discovery fab.DiscoveryService, peers []fab.Peer, filter fab.TargetFilter) ([]fab.Peer, error) {
258252

259253
if peers != nil && filter != nil {
260254
return nil, errors.New("If targets are provided, filter cannot be provided")

0 commit comments

Comments
 (0)