ci: fix garbage collection test

Author: ibhagwan

.github/workflows/ci.yaml

@@ -18,7 +18,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        rev: [nightly, v0.11.1]
+        rev: [nightly, v0.11.2]
         include:
           - os: macos-latest
             install-deps: brew update && brew install fzf ripgrep fd

lua/fzf-lua/shell.lua

@@ -38,6 +38,12 @@ function M.clear_protected()
   _protected = {}
 end
 
+function M.clear_registry()
+  _index = 0
+  _registry = {}
+  _protected = {}
+end
+
 -- creates a new address to listen to messages from actions. This is important
 -- if the user is using a custom fixed $NVIM_LISTEN_ADDRESS. Different neovim
 -- instances will then use the same path as the address and it causes a mess,

lua/fzf-lua/test/helpers.lua

@@ -35,7 +35,7 @@ local os_detect = {
   },
   MAC = { name = "MacOS", fn = function() return vim.fn.has("mac") == 1 end },
   LINUX = { name = "Linux", fn = function() return vim.fn.has("linux") == 1 end },
-  STABLE = { name = "Neovim stable", fn = function() return M.NVIM_VERSION() == "0.11.1" end },
+  STABLE = { name = "Neovim stable", fn = function() return M.NVIM_VERSION() == "0.11.2" end },
   NIGHTLY = { name = "Neovim nightly", fn = function() return vim.fn.has("nvim-0.12") == 1 end },
 }
 
@@ -139,7 +139,7 @@ M.new_child_neovim = function()
             _G._fzf_load_called = nil
           end,
         },
-        -- TODO: why is gc called with builtin with this one?
+        -- Using _fzf_cli_args so we can test keymap.fzf.load actions.load (api.events)
         -- keymap = { fzf = { true, load = function() _G._fzf_load_called = true end } }
         fzf_cli_args = "--bind=" .. FzfLua.libuv.shellescape("load:+execute-silent:"
           .. FzfLua.shell.stringify_data(function(_, _, _)

tests/win_spec.lua

@@ -36,26 +36,40 @@ T["win"]["hide"]["ensure gc called after win hidden (#1782)"] = function()
       return setmetatable(t, mt)
     end
   ]])
-  child.wait_until(function()
-    if helpers.IS_WIN() then
-      local hidden_fzf_bufnr = child.lua_get(
-        [[(FzfLua.utils.fzf_winobj() or {})._hidden_fzf_bufnr]])
-      if hidden_fzf_bufnr ~= vim.NIL then
-        local chan = child.lua_get(([=[vim.bo[%s].channel]=]):format(hidden_fzf_bufnr))
-        child.api.nvim_chan_send(chan, vim.keycode("<c-c>"))
-      end
+  if helpers.IS_WIN() then
+    local hidden_fzf_bufnr = child.lua_get(
+      [[(FzfLua.utils.fzf_winobj() or {})._hidden_fzf_bufnr]])
+    if hidden_fzf_bufnr ~= vim.NIL then
+      local chan = child.lua_get(([=[vim.bo[%s].channel]=]):format(hidden_fzf_bufnr))
+      child.api.nvim_chan_send(chan, vim.keycode("<c-c>"))
     end
-    -- TODO: why isn't gc called with the builtin previewr
-    -- child.lua([[FzfLua.files{ previewer = 'builtin' }]])
-    child.lua([[FzfLua.files{ previewer = false }]])
-    child.wait_until(function()
-      return child.lua_get([[_G._fzf_load_called]]) == true
-    end)
-    child.lua([[FzfLua.hide()]])
-    child.wait_until(function()
-      return child.lua_get([[_G._fzf_load_called]]) == vim.NIL
-    end)
-    child.lua([[collectgarbage('collect')]])
+  end
+  child.lua([[FzfLua.files{ previewer = 'builtin' }]])
+  -- child.lua([[FzfLua.files{ previewer = false }]])
+  child.wait_until(function()
+    return child.lua_get([[_G._fzf_load_called]]) == true
+  end)
+  child.lua([[FzfLua.hide()]])
+  child.wait_until(function()
+    return child.lua_get([[_G._fzf_load_called]]) == vim.NIL
+  end)
+  -- Clear the function registry to unref all the stored opts
+  -- and verify we're cleared by testing the id of a new func
+  child.lua([[FzfLua.shell.clear_registry()]])
+  eq(child.lua_get([[FzfLua.shell.register_func(function() end)]]), 1)
+  -- Open a new picker to unref the hidden window object, since
+  -- we cleared the registry we need to re-setup the load event
+  child.lua([[FzfLua.buffers{
+    previewer = false,
+    -- both keymap.fzf and actions work here
+    -- keymap = { fzf = { load = function() _G._fzf_load_called = true end } }
+    actions = { load = { fn = function() _G._fzf_load_called = true end, exec_silent = true } },
+  }]])
+  child.wait_until(function()
+    return child.lua_get([[_G._fzf_load_called]]) == true
+  end)
+  child.lua([[collectgarbage('collect')]])
+  child.wait_until(function()
     return child.lua_get([[_G._gc_called]]) == true
   end)
 end