chore(jj): fix types, warn when jj is not found

chore(defaults): fix lint warnings

Author: ibhagwan

lua/fzf-lua/defaults.lua

@@ -10,9 +10,10 @@ function M._default_previewer_fn()
   if type(winopts) == "function" then
     winopts = winopts() or {}
     winopts.preview = type(winopts.preview) == "table" and winopts.preview or {}
-    winopts.preview.default = winopts.preview.default or M.defaults.winopts.preview.default
+    winopts.preview.default = winopts.preview.default
+        or utils.map_get(M.defaults, "winopts.preview.default")
   end
-  local previewer = M.globals.default_previewer or winopts.preview.default
+  local previewer = M.globals.default_previewer or utils.map_get(winopts, "preview.default")
   -- the setup function cannot have a custom previewer as deepcopy
   -- fails with stack overflow while trying to copy the custom class
   -- the workaround is to define the previewer as a function instead
@@ -894,11 +895,16 @@ M.defaults.git                   = {
   },
 }
 
+---Jujutsu pickers parent table.
+---@class fzf-lua.config.JJ
+---@field files     fzf-lua.config.JJFiles
 M.defaults.jj                    = {
   ---Jujutsu tracked files.
+  ---@diagnostic disable-next-line: param-type-mismatch
+  ---@class fzf-lua.config.JJFiles: fzf-lua.config.GitFiles
   files = vim.tbl_deep_extend("force", M.defaults.git.files, {
-    cmd               = "jj file list --ignore-working-copy",
-    git_icons         = false,
+    cmd       = "jj file list --ignore-working-copy",
+    git_icons = false,
   }),
 }
 

lua/fzf-lua/providers/jj.lua

@@ -6,6 +6,10 @@ local config = require "fzf-lua.config"
 local M = {}
 
 local function set_jj_cwd_args(opts)
+  if vim.fn.executable("jj") ~= 1 then
+    utils.warn(string.format("'%s' requires jj (https://github.com/jj-vcs/jj).", utils.get_info().cmd))
+    return
+  end
   -- verify cwd is a jj repo, override user supplied
   -- cwd if cwd isn't a jj repo, error was already
   -- printed to `:messages` by 'path.jj_root'
@@ -16,13 +20,13 @@ local function set_jj_cwd_args(opts)
   return opts
 end
 
----@param opts table|{}?
+---@param opts fzf-lua.config.JJFiles|{}?
 ---@return thread?, string?, table?
 M.files = function(opts)
   opts = config.normalize_opts(opts, "jj.files")
   if not opts then return end
   opts = set_jj_cwd_args(opts)
-  if not opts.cwd then return end
+  if not opts or not opts.cwd then return end
   return core.fzf_exec(opts.cmd, opts)
 end